From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6220EB64DC for ; Tue, 18 Jul 2023 20:17:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230377AbjGRUQ4 (ORCPT ); Tue, 18 Jul 2023 16:16:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230333AbjGRUQy (ORCPT ); Tue, 18 Jul 2023 16:16:54 -0400 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 312DAF9; Tue, 18 Jul 2023 13:16:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=JcHNL3a69uZIHkUdSEgchC92wu1+8vIvXIawZDtpUb4=; b=ifjb+2EVEa5UWdvG2Oi7hlfSD2 0gv9PHEmRfK71DBmFd+JtmT8JxzqmTdOaMIdpXif9oBeC/yIA85G+fEma7vkL2+y/ZhYUolIhjq3X u5e9j9mGlcrknJCU0pxRCog6h23PaSOe05MOk8Ccd4wWzysTWZWcNAGzfyqvPeHwh5vE=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1qLr7d-001efI-VJ; Tue, 18 Jul 2023 22:16:37 +0200 Date: Tue, 18 Jul 2023 22:16:37 +0200 From: Andrew Lunn To: Michael Walle Cc: Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Yisen Zhuang , Salil Mehta , Florian Fainelli , Broadcom internal kernel review list , Marek =?iso-8859-1?Q?Beh=FAn?= , Xu Liang , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Simon Horman Subject: Re: [PATCH net-next v3 03/11] net: phy: replace is_c45 with phy_accces_mode Message-ID: <16c19cff-cca7-43fa-97a8-c4e74f033b0b@lunn.ch> References: <20230620-feature-c45-over-c22-v3-0-9eb37edf7be0@kernel.org> <20230620-feature-c45-over-c22-v3-3-9eb37edf7be0@kernel.org> <509889a3-f633-40b0-8349-9ef378818cc7@lunn.ch> <66d9daa106d7840e972dba35914e6983@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66d9daa106d7840e972dba35914e6983@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Maybe we need to clarify what "has c22/c45 registers space" actually > means. Responds to MII c22/c45 access? No. That is not what it means to me. Bus transactions and register spaces are different. There are C22 registers, and there are C45 registers. The bus can do C22 transfers, and it can do C45 transfers. C22 registers can be access using C22 bus transfers. C45 registers can be accessed using either C45 bus transfers, or indirectly via C45 over C22 transfers. Currently, there is no C22 over C45, but given the oddball Realtek PHY Russell is talking about in an SFP, it might have a proprietary C22 over C45? Andrew