From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C95D9C7EE29 for ; Tue, 23 May 2023 12:35:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236930AbjEWMfU (ORCPT ); Tue, 23 May 2023 08:35:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229525AbjEWMfR (ORCPT ); Tue, 23 May 2023 08:35:17 -0400 Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com [209.85.167.42]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98E1FC4 for ; Tue, 23 May 2023 05:35:16 -0700 (PDT) Received: by mail-lf1-f42.google.com with SMTP id 2adb3069b0e04-4f4b80bf93aso1237663e87.0 for ; Tue, 23 May 2023 05:35:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1684845255; x=1687437255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=5VStAuEVhC2bCRmusIaySDz/SK/sdnCdNupplahYT9Q=; b=ItC/HSLvWJai35Wq6AoHYCugrh1LBbE8UpOeF0LZVCgHMMuV5hMMYIbe1zYqapEzZJ y9qiz4LK4kmoGWJlYxkUa0Bt3qeSeOjduzxYdl39PYg/ylqDgH5jlzcd7WxnO4VPT5N0 Z8qQqeEaK8cnIBjgmvP9V2x6KX2NW+Se1BArQFKRgVP3VjpxjzMBFLpoz/Gtqqv1yQTl 7NiNVG/oCUfyV83xI602JFpSScw6flnFy1/MnxZOscieb2m4ZROMysYBStgB/NAsMR9w GaAhdPaHN2y7KutWw6dLQfLLxSMco1Rm3sRDnifsOgwIlTNWluqVqLd0iA4C01+H+PSm IXzg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684845255; x=1687437255; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5VStAuEVhC2bCRmusIaySDz/SK/sdnCdNupplahYT9Q=; b=jbuRZkoge48BZFaNf9yQ3D3k+M8yEMqNHeVfPbHzIjnwalep1xUmgCVQfcEr39RSKZ OS/YOp5W6xJaBxknVFAxtJm4obtdDWwsFPNzW9sN7DT5l5mjEW0BeRvi6B/OIGsqdwhP JseHMozy705qwaD3Og9sygyd30yQwKIpGI9Te4zWJj3C5J9LrpqwidEPPq+64/9uuIMe 0GMd+PQFNgzjIxvZX0w8TzcHQM/Sryzb6OM9XCK8kIMiNRSUnOE+fI6Iev/xa5NCWY+Z Ipjb1BmjocQsPXnLeMlmRkV24d3u1Xg9cJef2K+euiAUXb0awJq96fxMgQiHVcuVmjNG sRVA== X-Gm-Message-State: AC+VfDxWBt6kBHfKlTKkP4QxYH7SUcajKSxw08zsf/cCF+QxHZXyTvpv g74Ig/Y93OAvoFDorkROiBw+Tg== X-Google-Smtp-Source: ACHHUZ6mRNSCPuwh1780ZJPAelP5liz4bXxJaS2j4Brr3xJN1o0gnDBB9N1MkO7iAWK5UecFSO/ybg== X-Received: by 2002:a19:f610:0:b0:4f4:b3e2:ff5a with SMTP id x16-20020a19f610000000b004f4b3e2ff5amr1176411lfe.50.1684845254928; Tue, 23 May 2023 05:34:14 -0700 (PDT) Received: from [10.10.15.175] ([192.130.178.91]) by smtp.gmail.com with ESMTPSA id m11-20020a19520b000000b004f13f4ec267sm1312723lfb.186.2023.05.23.05.34.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 05:34:14 -0700 (PDT) Message-ID: <16c5ddb7-f5a4-d70b-ce0c-32aa6674fc98@linaro.org> Date: Tue, 23 May 2023 15:34:13 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4] drm/msm/dp: enable HDP plugin/unplugged interrupts at hpd_enable/disable Content-Language: en-GB To: Bjorn Andersson , Kuogee Hsieh Cc: robdclark@gmail.com, sean@poorly.run, swboyd@chromium.org, dianders@chromium.org, vkoul@kernel.org, daniel@ffwll.ch, airlied@gmail.com, agross@kernel.org, marijn.suijten@somainline.org, quic_abhinavk@quicinc.com, quic_jesszhan@quicinc.com, quic_sbillaka@quicinc.com, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org References: <1684796565-17138-1-git-send-email-quic_khsieh@quicinc.com> <20230523123504.3xjssy6ktgrsdewi@ripper> From: Dmitry Baryshkov In-Reply-To: <20230523123504.3xjssy6ktgrsdewi@ripper> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23/05/2023 15:35, Bjorn Andersson wrote: > On Mon, May 22, 2023 at 04:02:45PM -0700, Kuogee Hsieh wrote: >> The internal_hpd flag is set to true by dp_bridge_hpd_enable() and set to >> false by dp_bridge_hpd_disable() to handle GPIO pinmuxed into DP controller >> case. HDP related interrupts can not be enabled until internal_hpd is set >> to true. At current implementation dp_display_config_hpd() will initialize >> DP host controller first followed by enabling HDP related interrupts if >> internal_hpd was true at that time. Enable HDP related interrupts depends on >> internal_hpd status may leave system with DP driver host is in running state >> but without HDP related interrupts being enabled. This will prevent external >> display from being detected. Eliminated this dependency by moving HDP related >> interrupts enable/disable be done at dp_bridge_hpd_enable/disable() directly >> regardless of internal_hpd status. >> >> Changes in V3: >> -- dp_catalog_ctrl_hpd_enable() and dp_catalog_ctrl_hpd_disable() >> -- rewording ocmmit text >> >> Changes in V4: >> -- replace dp_display_config_hpd() with dp_display_host_start() >> -- move enable_irq() at dp_display_host_start(); > > I think what Dmitry was asking for was that you remove the disable_irq() > from dp_display_request_irq(), but perhaps I missed some argumentation > for why that can't/shouldn't be done? > Yes, I was asking to get it removed. Kuogee, is there any reason for keeping the enable_irq() / disable_irq() calls? -- With best wishes Dmitry