From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46E3AC3B186 for ; Mon, 10 Feb 2020 21:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1BD092085B for ; Mon, 10 Feb 2020 21:42:21 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=linux.microsoft.com header.i=@linux.microsoft.com header.b="ld3OZ01z" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727675AbgBJVmU (ORCPT ); Mon, 10 Feb 2020 16:42:20 -0500 Received: from linux.microsoft.com ([13.77.154.182]:53486 "EHLO linux.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727003AbgBJVmU (ORCPT ); Mon, 10 Feb 2020 16:42:20 -0500 Received: from [10.137.112.97] (unknown [131.107.147.225]) by linux.microsoft.com (Postfix) with ESMTPSA id 20CA020B9C02; Mon, 10 Feb 2020 13:42:19 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 20CA020B9C02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1581370939; bh=c0TukwmucTy5RNLXk2xO2mRGV73gFeBoYmLm/yU+Twk=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=ld3OZ01zdXOclFIWk5fVyoBn2BoPxcahsNhaHF7p201N+Pyo3e7z2DMLjXSe13BV7 i1Krue3xOgrTAUbmrNVFeHPW8K4YbUjvDrwjXdTvj6GuHJ37Xm7LLLWCBi2S63M8nK ZcWNhPKfwTWZ7u6/IyF1QHWx5UQyyGK+MccGbpxA= Subject: Re: [PATCH] IMA: Add log statements for failure conditions. To: Joe Perches , Lakshmi Ramasubramanian , Mimi Zohar , linux-integrity@vger.kernel.org, khan@linuxfoundation.org Cc: sashal@kernel.org, linux-kernel@vger.kernel.org References: <20200207195346.4017-1-tusharsu@linux.microsoft.com> <20200207195346.4017-2-tusharsu@linux.microsoft.com> <1581253027.5585.671.camel@linux.ibm.com> <41d61aa5-db98-6291-d91f-104f029c897f@linux.microsoft.com> <13eb9760ba13cee2f25c74c665198faac6a5a2f3.camel@perches.com> From: Tushar Sugandhi Message-ID: <16d31f10-012c-5b3c-7069-841070f6b84f@linux.microsoft.com> Date: Mon, 10 Feb 2020 13:42:18 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <13eb9760ba13cee2f25c74c665198faac6a5a2f3.camel@perches.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-02-10 8:50 a.m., Joe Perches wrote: > On Mon, 2020-02-10 at 08:40 -0800, Lakshmi Ramasubramanian wrote: >> On 2/9/20 6:46 PM, Joe Perches wrote: >> >>>> In addition, as Shuah Khan suggested for the security/integrity/ >>>> directory, "there is an opportunity here to add #define pr_fmt(fmt) >>>> KBUILD_MODNAME ": " fmt to integrity.h and get rid of duplicate >>>> defines." >> >> Good point - we'll make that change. >> >> With Joe Perches patch (waiting for it to be re-posted), >>>> are all the pr_fmt definitions needed in each file in the >>>> integrity/ima directory? >>> >>> btw Tushar and Lakshmi: >>> >>> I am not formally submitting a patch here. >>> >>> I was just making suggestions and please do >>> with it as you think appropriate. >> >> Joe - it's not clear to me what you are suggesting. >> We'll move the #define for pr_fmt to integrity.h. >> >> What's other changes are you proposing? > > https://lore.kernel.org/lkml/4b4ee302f2f97e3907ab03e55a92ccd46b6cf171.camel@perches.com/ > Thanks Joe. Joe, Shuah: Could one of you please clarify if the changes proposed in the above URL will be part of Shuah's future patchset? Or should I include those in my patchset? I am referring to the following snippet in security/integrity/integrity.h. +#ifdef pr_fmt +#undef pr_fmt +#endif + +#define pr_fmt(fmt) KBUILD_MODNAME ": " KBUILD_BASENAME ": " fmt + If I add the above in my patchset, I believe I should remove #defines for pr_fmt in the .c files under /security/integrity? (except the below one) latform_certs/efi_parser.c:#define pr_fmt(fmt) "EFI: "fmt Please let me know. Thanks, Tushar