From: Joe Perches <joe@perches.com>
To: Karolina Drobnik <karolinadrobnik@gmail.com>,
outreachy-kernel@googlegroups.com
Cc: gregkh@linuxfoundation.org, forest@alittletooquiet.net,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: vt6655: Rename `dwAL2230InitTable` array
Date: Wed, 20 Oct 2021 06:44:19 -0700 [thread overview]
Message-ID: <16db455b46f130300b5c346160aa434616e4f6b4.camel@perches.com> (raw)
In-Reply-To: <20211020132811.417341-1-karolinadrobnik@gmail.com>
On Wed, 2021-10-20 at 14:28 +0100, Karolina Drobnik wrote:
> Drop Hungarian notation prefix in `dwAL2230InitTable` array.
> Change it to use snake case.
>
> Fix issue detected by checkpatch.pl:
> CHECK: Avoid CamelCase: <dwAL2230InitTable>
Seems fine.
trivial suggestion:
> diff --git a/drivers/staging/vt6655/rf.c b/drivers/staging/vt6655/rf.c
[]
> @@ -33,7 +33,7 @@
> #define SWITCH_CHANNEL_DELAY_AL7230 200 /* us */
> #define AL7230_PWR_IDX_LEN 64
>
> -static const unsigned long dwAL2230InitTable[CB_AL2230_INIT_SEQ] = {
> +static const unsigned long al2230_init_table[CB_AL2230_INIT_SEQ] = {
> 0x03F79000 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
> 0x03333100 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
> 0x01A00200 + (BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW,
In this file there are more than 100 uses of
(BY_AL2230_REG_LEN << 3) + IFREGCTL_REGW
Maybe add a define for it and substitute the uses for the define.
next prev parent reply other threads:[~2021-10-20 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 13:28 Karolina Drobnik
2021-10-20 13:44 ` Joe Perches [this message]
2021-10-20 14:09 ` Joe Perches
2021-10-20 14:16 ` [Outreachy kernel] " Julia Lawall
2021-10-20 15:56 ` Karolina Drobnik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16db455b46f130300b5c346160aa434616e4f6b4.camel@perches.com \
--to=joe@perches.com \
--cc=forest@alittletooquiet.net \
--cc=gregkh@linuxfoundation.org \
--cc=karolinadrobnik@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=outreachy-kernel@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®