From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madrid.collaboradmins.com (madrid.collaboradmins.com [46.235.227.194]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4E9415E8B; Mon, 29 Apr 2024 08:13:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=46.235.227.194 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714378427; cv=none; b=VkDodR6QUJqCb9vLPNQgoet4ZnLY6PTqLq1BooZ07EOY3ucSpdujitYwwDinGMbANlTrxSeq32kDLPcWgYG6xk1YnwiRA3rBT/Hx4uXdBU9SCIdp8pgQfKOG7SYeBnjpLuRitnBiwolU172SahwRD3NmVY8hxkS4cgngA5CZiJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1714378427; c=relaxed/simple; bh=b1SZPFe+NuDhrNOpdqekcjo4NtR3t0eI9LUZWGBoZ2U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=h68dIK0sbdgJfhWQLp7agIkmneqInIU7tjHoQnu64+j/JkrVCVavaIj+MdtuR/7SM8pw0LyyJ1atMDv2N3KwD4SSC2i4HJbPqXvkzZRQxxGm6hyzfbQb1cif1BiF4rG5xzJ/g8OhIDH8yu0dj2chessMa6ECVmCf4iQrL+tfirc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com; spf=pass smtp.mailfrom=collabora.com; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b=Vg1xro7D; arc=none smtp.client-ip=46.235.227.194 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=collabora.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=collabora.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="Vg1xro7D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1714378423; bh=b1SZPFe+NuDhrNOpdqekcjo4NtR3t0eI9LUZWGBoZ2U=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Vg1xro7DPLUieeWf4MObveLWKyTiikAkK/pIXlJjlaVz1tL7cQAaQZ/D4oqAM4zxl r8HgExOz8TWgAjPjIxNuvBgu4ocTRCXoe8gtXqDUEARqmN+YrYdXZLXI9l8ql1MN+8 1UdT9QCggwJOAhtCkRKpui32Xh+CIYbhY6sVlUF67I1mH0QdznTYVqDkbvnoXSwpxK zujgqfYEcjqfs0nQnJuNXOWJcbALcZY3vPvko8QDLBQb63YNEE57FZZNhUPaL1OujJ ZJJgXw9809tFTIFZQUI5dJ5p6oLHAZnuPjwxMfyIY/I6AgKlJdGDNkurH9MsNO9/P9 S8lBqPVKa4y1Q== Received: from [100.113.186.2] (cola.collaboradmins.com [195.201.22.229]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: kholk11) by madrid.collaboradmins.com (Postfix) with ESMTPSA id 1BBF6378134F; Mon, 29 Apr 2024 08:13:43 +0000 (UTC) Message-ID: <16df315e-8a05-49a4-ac07-d1ed150c9317@collabora.com> Date: Mon, 29 Apr 2024 10:13:42 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv To: Christophe JAILLET , Pavel Machek , Lee Jones , Matthias Brugger Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: From: AngeloGioacchino Del Regno Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 28/04/24 20:27, Christophe JAILLET ha scritto: > In "struct mt6370_priv", the 'reg_cfgs' field is unused. > > Moreover the "struct reg_cfg" is defined nowhere. Neither in this file, nor > in a global .h file, so it is completely pointless. > > Remove it. Sure > > Found with cppcheck, unusedStructMember. > > So, remove it. Again?! :-P > > Signed-off-by: Christophe JAILLET Anyway, this commit misses a Fixes tag; please add the relevant one, after which, Reviewed-by: AngeloGioacchino Del Regno > --- > Compile tested only. > --- > drivers/leds/rgb/leds-mt6370-rgb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/leds/rgb/leds-mt6370-rgb.c b/drivers/leds/rgb/leds-mt6370-rgb.c > index 448d0da11848..359ef00498b4 100644 > --- a/drivers/leds/rgb/leds-mt6370-rgb.c > +++ b/drivers/leds/rgb/leds-mt6370-rgb.c > @@ -149,7 +149,6 @@ struct mt6370_priv { > struct regmap_field *fields[F_MAX_FIELDS]; > const struct reg_field *reg_fields; > const struct linear_range *ranges; > - struct reg_cfg *reg_cfgs; > const struct mt6370_pdata *pdata; > unsigned int leds_count; > unsigned int leds_active;