From: avoidr@riseup.net
To: Guenter Roeck <linux@roeck-us.net>
Cc: Rudolf Marek <r.marek@assembler.cz>,
Jean Delvare <jdelvare@suse.com>,
linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org,
Robert Karszniewicz <avoidr@firemail.cc>,
linux-hwmon-owner@vger.kernel.org
Subject: Re: [PATCH v3 1/1] hwmon: (k8temp) update to use new hwmon registration API
Date: Sun, 21 Jul 2019 13:37:31 -0700 [thread overview]
Message-ID: <16e03db49372a5f240b241f985f8685c@riseup.net> (raw)
In-Reply-To: <20190721151408.GA13373@roeck-us.net>
On 2019-07-21 17:14, Guenter Roeck wrote:
> On Sun, Jul 21, 2019 at 02:00:51PM +0200, Robert Karszniewicz wrote:
>> Removes:
>> - hwmon_dev from k8temp_data struct, as that is now passed
>> to callbacks, anyway.
>> - other k8temp_data struct fields, too.
>> - k8temp_update_device()
>>
>> Also reduces binary size:
>> text data bss dec hex filename
>> 4139 1448 0 5587 15d3 drivers/hwmon/k8temp.ko.bak
>> 3103 1220 0 4323 10e3 drivers/hwmon/k8temp.ko
>>
>> Signed-off-by: Robert Karszniewicz <avoidr@firemail.cc>
>> Signed-off-by: Robert Karszniewicz <avoidr@riseup.net>
>
> Applied.
Thank you! It's been a joy!
>> ---
>> Changes from v2:
>> - if (data->swap_core_select)
>> - core ^= 1;
>> + core ^= data->swap_core_select;
>>
>> However, that produces slightly more .text than v2, and is a tad too
>> "tricky", I personally find.
>>
> Interesting - for me it produces ~30 bytes less code (with gcc 7.4.0).
Strange. I just verified to make sure and I do get ~30 bytes /more/ code
(with gcc 9.1.0).
next prev parent reply other threads:[~2019-07-21 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <BVOE7U9MRMZY.38N6DGWH9KX7H@HP>
2019-07-20 22:46 ` [PATCH 1/2] " Guenter Roeck
2019-07-21 12:00 ` [PATCH v3 1/1] " Robert Karszniewicz
2019-07-21 15:14 ` Guenter Roeck
2019-07-21 20:37 ` avoidr [this message]
2019-07-22 0:03 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e03db49372a5f240b241f985f8685c@riseup.net \
--to=avoidr@riseup.net \
--cc=avoidr@firemail.cc \
--cc=jdelvare@suse.com \
--cc=linux-hwmon-owner@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=r.marek@assembler.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®