From: "Arnd Bergmann" <arnd@arndb.de>
To: "Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Arnd Bergmann" <arnd@kernel.org>
Cc: "Linus Walleij" <linusw@kernel.org>,
"Bartosz Golaszewski" <brgl@kernel.org>,
"Alexander Sverdlin" <alexander.sverdlin@gmail.com>,
linux-kernel@vger.kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] gpiolib: move legacy interface into linux/gpio/legacy.h
Date: Tue, 28 Apr 2026 18:17:32 +0200 [thread overview]
Message-ID: <16e058af-dfa9-43b1-be6e-47150d6c7cb0@app.fastmail.com> (raw)
In-Reply-To: <afDX7WabVPVce4kc@ashevche-desk.local>
On Tue, Apr 28, 2026, at 17:53, Andy Shevchenko wrote:
> On Tue, Apr 28, 2026 at 05:45:07PM +0200, Arnd Bergmann wrote:
>
>> Split the old contents from gpio.h for clarity. Ideally any driver
>> that still includes linux/gpio.h can now be ported over to use
>> either linux/gpio/legacy.h or linux/gpio/consumer.h, with the
>> original file getting removed once that is complete.
>>
>> No functional changes intended for now.
>
> But I'm not sure why. The idea to kill gpio.h completely, no need to keep it
> longer than legacy stuff exists. I don't take 'clarity' as a good justification
> here, since the old header are still there (however just a shallow wrapper).
I currently count 59 files that use the legacy header,
and I have a patch to change those over to include it
directly. I could post it now, but the exact list seems to
be changing by the day at the moment. It may be better
to split it up by subsystem once the first patch is merged,
or it could go through the gpio tree.
There are another 94 uses of linux/gpio.h that should
be linux/gpio/consumer.h instead. That patch is of course
trivial as well, but I have not prepared it yet.
I don't think the legacy stuff is going away any time soon,
so removing it from linux/gpio.h with the follow-up patch
should help avoid new instances getting merged unnoticed.
Arnd
next prev parent reply other threads:[~2026-04-28 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 15:45 Arnd Bergmann
2026-04-28 15:53 ` Andy Shevchenko
2026-04-28 16:17 ` Arnd Bergmann [this message]
2026-04-29 8:48 ` Bartosz Golaszewski
2026-05-04 7:59 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e058af-dfa9-43b1-be6e-47150d6c7cb0@app.fastmail.com \
--to=arnd@arndb.de \
--cc=alexander.sverdlin@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=arnd@kernel.org \
--cc=brgl@kernel.org \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®