mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Asai Thambi SP <asamymuthupa@micron.com>
To: Jens Axboe <axboe@kernel.dk>
Cc: <linux-kernel@vger.kernel.org>,
	Sam Bradshaw <sbradshaw@micron.com>,
	Selvan Mani <smani@micron.com>,
	Rajesh Kumar Sambandam <rsambandam@micron.com>,
	Vignesh Gunasekaran <vgunasekaran@micron.com>
Subject: [PATCH 03/10] mtip32xx: Remove unwanted code from taskfile error handler
Date: Mon, 22 Feb 2016 21:00:38 -0800	[thread overview]
Message-ID: <16e514e7-2eda-4fe1-67dc-71e304976db4@micron.com> (raw)


Remove setting and clearing MTIP_PF_EH_ACTIVE_BIT flag in
mtip_handle_tfe() as they are redundant. Also avoid waking
up service thread from mtip_handle_tfe() because it is
already woken up in case of taskfile error.

Signed-off-by: Selvan Mani <smani@micron.com>
Signed-off-by: Rajesh Kumar Sambandam <rsambandam@micron.com>
Signed-off-by: Asai Thambi S P <asamymuthupa@micron.com>
---
 drivers/block/mtip32xx/mtip32xx.c |    9 +--------
 1 files changed, 1 insertions(+), 8 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 4dfe2be..30f8246 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -618,8 +618,6 @@ static void mtip_handle_tfe(struct driver_data *dd)
 
     port = dd->port;
 
-    set_bit(MTIP_PF_EH_ACTIVE_BIT, &port->flags);
-
     if (test_bit(MTIP_PF_IC_ACTIVE_BIT, &port->flags)) {
         cmd = mtip_cmd_from_tag(dd, MTIP_TAG_INTERNAL);
         dbg_printk(MTIP_DRV_NAME " TFE for the internal command\n");
@@ -628,7 +626,7 @@ static void mtip_handle_tfe(struct driver_data *dd)
             cmd->comp_func(port, MTIP_TAG_INTERNAL,
                     cmd, PORT_IRQ_TF_ERR);
         }
-        goto handle_tfe_exit;
+        return;
     }
 
     /* clear the tag accumulator */
@@ -771,11 +769,6 @@ static void mtip_handle_tfe(struct driver_data *dd)
         }
     }
     print_tags(dd, "reissued (TFE)", tagaccum, cmd_cnt);
-
-handle_tfe_exit:
-    /* clear eh_active */
-    clear_bit(MTIP_PF_EH_ACTIVE_BIT, &port->flags);
-    wake_up_interruptible(&port->svc_wait);
 }
 
 /*
-- 
1.7.1

                 reply	other threads:[~2016-02-23  5:00 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16e514e7-2eda-4fe1-67dc-71e304976db4@micron.com \
    --to=asamymuthupa@micron.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rsambandam@micron.com \
    --cc=sbradshaw@micron.com \
    --cc=smani@micron.com \
    --cc=vgunasekaran@micron.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®