From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75684C001DD for ; Wed, 5 Jul 2023 07:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232039AbjGEHCW (ORCPT ); Wed, 5 Jul 2023 03:02:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34998 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231653AbjGEHCU (ORCPT ); Wed, 5 Jul 2023 03:02:20 -0400 Received: from ex01.ufhost.com (ex01.ufhost.com [61.152.239.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07929134; Wed, 5 Jul 2023 00:02:18 -0700 (PDT) Received: from EXMBX166.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX166", Issuer "EXMBX166" (not verified)) by ex01.ufhost.com (Postfix) with ESMTP id 12C9524E2B1; Wed, 5 Jul 2023 15:02:10 +0800 (CST) Received: from EXMBX068.cuchost.com (172.16.6.68) by EXMBX166.cuchost.com (172.16.6.76) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 15:02:10 +0800 Received: from [192.168.120.57] (171.223.208.138) by EXMBX068.cuchost.com (172.16.6.68) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Wed, 5 Jul 2023 15:02:09 +0800 Message-ID: <16e71854-cfd9-b93b-6221-864a56a50678@starfivetech.com> Date: Wed, 5 Jul 2023 15:02:08 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v4 2/3] spi: cadence-quadspi: Add clock configuration for StarFive JH7110 QSPI Content-Language: en-US To: Conor Dooley CC: , , , , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Emil Renner Berthing" , Ziv Xu References: <20230704090453.83980-1-william.qiu@starfivetech.com> <20230704090453.83980-3-william.qiu@starfivetech.com> <20230704-gooey-lair-2bc45bbd163c@spud> From: William Qiu In-Reply-To: <20230704-gooey-lair-2bc45bbd163c@spud> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [171.223.208.138] X-ClientProxiedBy: EXCAS064.cuchost.com (172.16.6.24) To EXMBX068.cuchost.com (172.16.6.68) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2023/7/5 0:36, Conor Dooley wrote: > Hey William, > > On Tue, Jul 04, 2023 at 05:04:52PM +0800, William Qiu wrote: >> Add QSPI clock operation in device probe. >> >> Signed-off-by: William Qiu >> Reviewed-by: Hal Feng >> Reported-by: kernel test robot >> Closes: https://lore.kernel.org/oe-kbuild-all/202306022017.UbwjjWRN-lkp@intel.com/ > > These Reported-by tags don't seem correct, given they were reports about > this patch, not the reason for it - but did you actually check that you > fixed the errors that the patch produces? > > This particular one seems to complain about a hunk that is still in the > patch & the CI running on the RISC-V patchwork is complaining about it. > > Cheers, > Conor. > I checked and found that I had only partially fixed it. I'll fix it in next version. Thanks for your comments. Best regards, William >> @@ -1840,6 +1858,8 @@ static int cqspi_resume(struct device *dev) >> struct spi_master *master = dev_get_drvdata(dev); >> >> clk_prepare_enable(cqspi->clk); >> + if (of_device_is_compatible(dev->of_node, "starfive,jh7110-qspi")) >> + clk_bulk_prepare_enable(cqspi->num_clks, cqspi->clks); >> cqspi_wait_idle(cqspi); >> cqspi_controller_init(cqspi); >> >> -- >> 2.34.1 >>