From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sg-1-19.ptr.blmpb.com (sg-1-19.ptr.blmpb.com [118.26.132.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E4B862D8773 for ; Tue, 18 Nov 2025 05:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=118.26.132.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763445420; cv=none; b=YH575ZtJNzsgnaef6MNO7VIPSIZ99l6lDqFWg0RWrkdH4a/wgjR6pu67PTd4j00zA/qkFmE6K4vSU9cQOyfBU4AzAgk4nppovkveXGQcBMqZd67lVhkMjoW1MdkCk+RJNCXwBohGww688nkH/uiRiOC8AopK5joHiBXak10zcRw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763445420; c=relaxed/simple; bh=+TTOWBmVVvGm0ThWj7sfk68OK1xH45hMceJ4QiV4yo4=; h=Content-Type:From:Cc:Subject:Message-Id:Mime-Version:In-Reply-To: References:Date:To; b=Lf4l9uD9jYQCHkMiQMtlmfJGz6f9JS4fYm2xPjIfL5HnIAM8IrJLwqMtjOFfqNnUsse2EIbDRRDRZ21gkmLkJNF5mA9+GFVDx0PjQOF8WWfq1U9vjHvaVRpEXW6kGOwYHx0HiFdVeGdHmtI1GX8X7bbhaE3ZCpq01NEvDU5lcpc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com; spf=none smtp.mailfrom=fnnas.com; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b=Eq9hN7Db; arc=none smtp.client-ip=118.26.132.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=fnnas.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=fnnas.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=fnnas-com.20200927.dkim.feishu.cn header.i=@fnnas-com.20200927.dkim.feishu.cn header.b="Eq9hN7Db" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=s1; d=fnnas-com.20200927.dkim.feishu.cn; t=1763445405; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=+TTOWBmVVvGm0ThWj7sfk68OK1xH45hMceJ4QiV4yo4=; b=Eq9hN7DbXKT/3p10GoR4gnnSwFB9NnHzePd5zMoYQEDf1WUFl1Cn/ZH/zA2Vmfg8hntTeH +kgSgNFxbMkT4qoM14RGMsbwsa+g/rhQ8LoNgNV6VvTdEvD9WEDKIJhUiZOGzj2cV9wN/D JK8Hpn50WQ22H+YYI601RPXMy8ifPG3FVNFssVJyxK9zbjYwT+MRo1r3Ix0k0h4omJCTcL Xmxc+JA6AOOZ5l+p845WK8Wozs+xZQhgZrAHXAaKAIa32t0MP5ZomAwqwvBD43/aCZVC86 KkL1B5L6j15MBU/KlmP1F/Vb3kc3oQaJnLG5Dm5Jb3mem/CtdDjdbuZAXvRQnw== X-Lms-Return-Path: Content-Type: text/plain; charset=UTF-8 User-Agent: Mozilla Thunderbird Organization: fnnas Received: from [192.168.1.104] ([39.182.0.153]) by smtp.feishu.cn with ESMTPS; Tue, 18 Nov 2025 13:56:42 +0800 From: "Yu Kuai" Cc: Subject: Re: [PATCH RESEND v5 2/7] blk-mq-sched: unify elevators checking for async requests Message-Id: <16e817ab-7444-4da8-bc92-38fa13cb407f@fnnas.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 In-Reply-To: References: <20251116035228.119987-1-yukuai@fnnas.com> <20251116035228.119987-3-yukuai@fnnas.com> Content-Transfer-Encoding: quoted-printable Reply-To: yukuai@fnnas.com Content-Language: en-US Date: Tue, 18 Nov 2025 13:56:40 +0800 X-Original-From: Yu Kuai To: "Bart Van Assche" , , , , "Yu Kuai" Hi, =E5=9C=A8 2025/11/18 7:35, Bart Van Assche =E5=86=99=E9=81=93: > On 11/15/25 7:52 PM, Yu Kuai wrote: >> +static inline bool blk_mq_sched_sync_request(blk_opf_t opf) >> +{ >> +=C2=A0=C2=A0=C2=A0 return op_is_sync(opf) && !op_is_write(opf); >> +} > > The name of this function suggests that it performs an action while it > only performs a test. Please consider renaming this function into e.g. > blk_mq_is_sync_read(). I think the suggested name reflects much more > clearly what this function does than "blk_mq_sched_sync_request()". > Yes, this sounds good. > Thanks, > > Bart. > --=20 Thanks, Kuai