From: Ping-Ke Shih <pkshih@realtek.com>
To: Luka Gejak <luka.gejak@linux.dev>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Michael Straube" <straube.linux@gmail.com>,
Peter Robinson <pbrobinson@gmail.com>,
Bitterblue Smith <rtl8821cerfe2@gmail.com>
Subject: RE: [PATCH v3 2/6] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables
Date: Wed, 23 Sep 2026 08:59:35 +0000 [thread overview]
Message-ID: <16eeca262aab43a798afeb806e88aac8@realtek.com> (raw)
In-Reply-To: <09c6a890906e4d4e93d8dcde41e2b808b7d9582c@linux.dev>
Luka Gejak <luka.gejak@linux.dev> wrote:
> >
> > Luka Gejak <luka.gejak@linux.dev> wrote:
> >
> > >
> > > Luka Gejak <luka.gejak@linux.dev> wrote:
> > > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> > > > +/*
> > > > + * Copyright(c) 2007-2017 Realtek Corporation
> > > > + * Copyright(c) Michael Straube <straube.linux@gmail.com>
> > > > + * Copyright(c) 2024-2026 Luka Gejak <luka.gejak@linux.dev>
> > > >
> > > I'm not sure if we should claim copyright year back to 2007?
> > >
> > > What would you prefer, just tell me and I will change it?
> > >
> > You can reference what Bitterblue did [1]. I don't have much study
> > about the copyright.
> >
> > [1] 1a7545784642 ("wifi: rtw88: Add rtw8814a.{c,h}")
> >
>
> He uses 2025, so should I copy his line for Realtek copyright header?
Maybe "Copyright(c) 2026 Realtek Corporation"
If needed, more copyright are also okay, but I don't know much about that.
You can study Documentation or somewhere to know more.
>
> Also I will address all comments and send v4 tonight/tomorrow morning.
No rush. Deeply what review the patches before sending is more important.
As this patchset is large LOC, one iteration spends me a lot of time. I'd
minimize iteration as few as possible.
Ping-Ke
next prev parent reply other threads:[~2026-09-23 8:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-21 15:43 [PATCH v3 0/6] wifi: rtw88: add RTL8723B/RTL8723BS support Luka Gejak
2026-09-21 15:43 ` [PATCH v3 1/6] wifi: rtw88: 8723b: add the RTL8723B register definitions Luka Gejak
2026-09-23 7:44 ` Ping-Ke Shih
2026-09-21 15:43 ` [PATCH v3 2/6] wifi: rtw88: 8723b: add the RTL8723B BB, RF and AGC tables Luka Gejak
2026-09-23 7:50 ` Ping-Ke Shih
2026-09-23 8:27 ` Luka Gejak
2026-09-23 8:34 ` Ping-Ke Shih
2026-09-23 8:44 ` Luka Gejak
2026-09-23 8:59 ` Ping-Ke Shih [this message]
2026-09-23 9:09 ` Luka Gejak
2026-09-21 15:43 ` [PATCH v3 3/6] wifi: rtw88: 8723b: add the RTL8723B chip driver Luka Gejak
2026-09-23 8:30 ` Ping-Ke Shih
2026-09-23 21:50 ` Luka Gejak
2026-09-21 15:43 ` [PATCH v3 4/6] wifi: rtw88: 8723bs: add the RTL8723BS SDIO bind Luka Gejak
2026-09-23 9:04 ` Ping-Ke Shih
2026-09-21 15:43 ` [PATCH v3 5/6] wifi: rtw88: 8723bs: enable building the RTL8723BS driver Luka Gejak
2026-09-21 15:43 ` [PATCH v3 6/6] MAINTAINERS: add entry for the RTL8723B rtw88 driver Luka Gejak
2026-09-21 16:25 ` Johannes Berg
2026-09-21 16:49 ` Luka Gejak
2026-09-21 18:14 ` Johannes Berg
2026-09-21 22:35 ` Jeff Johnson
2026-09-21 23:53 ` Luka Gejak
2026-09-22 0:28 ` Ping-Ke Shih
2026-09-22 0:43 ` Luka Gejak
2026-09-22 0:50 ` Ping-Ke Shih
2026-09-22 1:07 ` Luka Gejak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16eeca262aab43a798afeb806e88aac8@realtek.com \
--to=pkshih@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=pbrobinson@gmail.com \
--cc=rtl8821cerfe2@gmail.com \
--cc=straube.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®