From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6D8D3FBB6C for ; Thu, 18 Jun 2026 15:24:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781796302; cv=none; b=ROsabFJC+N9CiV2UtjO3NFMbcd7VOJYYCGmBy2VsJJCeePmifogctyub2Izpzg6ugF2f/Ddkzv76xeWOZjA81PE5Kq/ihGnjsE1pJThG4Na8e0GgdImRt3pW9Xuh3vo+5YMEyAgKy3oIRD9hBnYB8hqdQQQKaJevkGtpDIcEeGY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781796302; c=relaxed/simple; bh=ZfPLf442w3sL0RwDvNRk/yFGjnO35Q+6suC1CWmYzDk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZVqmrPHFUQJznihFil5SM0Fd+Gv+z4aekL9C/mOGbKbH+z3z0w62e6xUnqdWsy3daHZfGFrnlGx6Diz5zyZT1/NFkkXnUetUtaRFZuxOa8D1E0ezaZlqDKwuCZpXQg9IGDL+PcPzfCUs4kTAL4bm6+LtO+Bu21i3d7q+A4F1OFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=hE/VNCs2; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="hE/VNCs2" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-69e8aa31e9fso571692eaf.2 for ; Thu, 18 Jun 2026 08:24:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1781796299; x=1782401099; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=lBx2MJdHGb6d75Q1J7l/vf2fQDboake9HxhnnU/k+eg=; b=hE/VNCs2VydPoKqwaY0f9fOjiBb+Hf/9lINSfRojO12P5ZGpCjc2nCzC4V1oIj7uy+ VLhPXhy60a49UvRzLjcTZmmX5fXOhVs4cvr3mQetqIA39rubyfMpha6W6Ofb5gwAJRk3 W0cI8USeulj5OZpjQF07FA8Xzg6TD9BfOvfAM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781796299; x=1782401099; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=lBx2MJdHGb6d75Q1J7l/vf2fQDboake9HxhnnU/k+eg=; b=qENpHskHOxjjRlwkDneLhtCOyQQl58K4FOAQzNgrPJZWw+aY3i6yTF2dS0CfOHoH4/ uYIVchH2UbUyJNePoxpi5Bc8Y0B4rr7VZ08Sy2rNdHJTkAZsFaNb2FnLiAuBch1n2lpI CCGqSBO1iTk6HjCTTKI2S95kWlYBuvySqvvLazLeS5q0YZQ6TMmcf8QbaLEAWlIL37WD c1sk37dSVek3yGD176icXOv7Li4zNhctBqoGFf/asqA/TmB7u/eKXCyqf5+rVzNIqGPN OdywFggLVjyvAuWR28oJbJ83/sJG36UhZgdItLf4UVHIXT4agZ2Wq1HTUVxUYCWG1WFG jINw== X-Forwarded-Encrypted: i=1; AFNElJ/+tN94MDVqxZVMwH7kPCelRu/Wz9OJhrK3DfLIelUfGJ0XVAlN0DzLh4rf45/lkQ+JQjdJU2vleIrLHJ8=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6d71cZHXhFhQ2t/bXvFyAGiuzS8wtVPBlVX9QWtEtWdfV9UJb 0IgV1wh6xmMWz/dYFJA+mR6k3aGANfN59KZLYJKjfmw3tAjhQVAMsJtH5aoJ+Y4luJA= X-Gm-Gg: AfdE7cl9fHURq8E5bBHdP4FSqFzgz8c+GXt0qQvmFXWOkvOSZ0AKxLram75i7XtaoqQ wJ+TaAH/FESGEjcgf+rlgs8XJ08mt+0NPxkBFqHL95i+OLsSKLIKi03i6KIJaBTWMH4aOvltnlX juvrZAjJA9yLewk7LhYb0IaKRdto5RAC3M3fG3TfAHyOviQl6i3ViKdWKUNRusAhEhIU/593bPx 9QsJH05RwLNismRDbXoHwBqtC1Jon+sNzxxwPAzaX5yp5l4gCAH9HqKL99ZTICc7n0L7h+DzhcT 8zbt3hzUuHPJ4PiLW49FytOSzt5m1k60YJaiTItmt/GiI4OM2a+0OMJR0iYM9swh06LMUyAMaGr HbboOjQYTkDmCoxdStnuHz+j8/t2+SNtien3WAzzF/hXQAjTQj94Qvd5i3HDx9NytG0/uHRESLE FQ3oKwIj3/IvG6SQ6UGtAi X-Received: by 2002:a05:6820:174a:b0:69e:2e0a:58dd with SMTP id 006d021491bc7-6a0b618d9demr7357214eaf.38.1781796298724; Thu, 18 Jun 2026 08:24:58 -0700 (PDT) Received: from [192.168.1.14] ([38.15.57.99]) by smtp.gmail.com with ESMTPSA id 006d021491bc7-69f00b41ed1sm9150146eaf.0.2026.06.18.08.24.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 18 Jun 2026 08:24:57 -0700 (PDT) Message-ID: <16ef9ff1-4c98-4c89-aefa-734a9e775df2@linuxfoundation.org> Date: Thu, 18 Jun 2026 09:24:55 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] selftests: proc: include fcntl.h in proc-pidns To: Amin Vakil , Shuah Khan Cc: Aleksa Sarai , Christian Brauner , linux-kselftest@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Shuah Khan References: <20260618151444.124739-1-info@aminvakil.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20260618151444.124739-1-info@aminvakil.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 6/18/26 09:14, Amin Vakil wrote: > proc-pidns.c uses open() and O_* flags, but does not include > . This breaks the proc selftests build with errors such as: > > error: implicit declaration of function 'open' > error: 'O_WRONLY' undeclared > error: 'O_CREAT' undeclared > error: 'O_RDONLY' undeclared > > Include to provide the declaration and flag definitions. Did you install headers before compiling the test? > > Fixes: 5554d820f71c ("selftests/proc: add tests for new pidns APIs") > Tested with: > make -C tools/testing/selftests TARGETS=proc > > Signed-off-by: Amin Vakil > --- > tools/testing/selftests/proc/proc-pidns.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tools/testing/selftests/proc/proc-pidns.c b/tools/testing/selftests/proc/proc-pidns.c > index 25b9a2933c45..6f7c10fe97b3 100644 > --- a/tools/testing/selftests/proc/proc-pidns.c > +++ b/tools/testing/selftests/proc/proc-pidns.c > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > #include > #include thanks, -- Shuah