From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756211AbdCWWbg (ORCPT ); Thu, 23 Mar 2017 18:31:36 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38694 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751503AbdCWWbf (ORCPT ); Thu, 23 Mar 2017 18:31:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E65F97E9CB Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=hdegoede@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E65F97E9CB Subject: Re: [PATCH 2/5] mfd: intel_soc_pmic: Select designware i2c-bus driver To: Lee Jones , Andy Shevchenko References: <20170322112923.20200-1-hdegoede@redhat.com> <20170322112923.20200-3-hdegoede@redhat.com> <1490187220.19767.159.camel@linux.intel.com> <20170323164647.tyyqoziiy4jwg5vc@dell> Cc: "Rafael J . Wysocki" , Len Brown , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org From: Hans de Goede Message-ID: <16efec42-64cf-88e8-8ebb-cf9fdfc383c3@redhat.com> Date: Thu, 23 Mar 2017 23:31:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170323164647.tyyqoziiy4jwg5vc@dell> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 23 Mar 2017 22:31:35 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 23-03-17 17:46, Lee Jones wrote: > On Wed, 22 Mar 2017, Andy Shevchenko wrote: > >> On Wed, 2017-03-22 at 12:29 +0100, Hans de Goede wrote: >>> The Crystal Cove PMIC provides an ACPI OPRegion handler, which must be >>> available before other drivers using it are loaded, which is why >>> INTEL_SOC_PMIC is a bool. >>> >>> Just having the driver is not enough, the driver for the i2c-bus must >>> also be built in, to ensure this, this patch adds a select for it. >>> >> >>> While at it this patch also changes the human readable name of the >>> Kconfig >>> option to make clear the INTEL_SOC_PMIC option selects support for the >>> Intel Crystal Cove PMIC and documents why this is a bool. >> >> The above is what my patch does, I'm okay if the change is going with >> this series as long as Lee is on the same side. Otherwise I would prefer >> to go my changes first. > > I think this set is going to need to be rebase on top of MFD. This patch (2/5) and 3/5 should apply cleanly as they only touch drivers/mfd/Kconfig and mfd-for-next has only 1 commit touching Kconfig which is no where near the areas these 2 patches are making changes. So I believe they can be applied as is. As for the other patches, patch 1/5 is for the ACPI subsys, since you've requested changes to the Cherry Trail Whiskey Cove MFD driver I will squash 4/5 into the new version of that and 5/5 again is an ACPI patch. Regards, Hans > >>> Cc: Andy Shevchenko >>> Signed-off-by: Hans de Goede >>> --- >>> Note this patch will partially conflicts with (contains the same >>> changes as) >>> a patch in Andy Shevchenko's tree. >>> --- >>> drivers/mfd/Kconfig | 7 +++++-- >>> 1 file changed, 5 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig >>> index d427a10..0c6a967 100644 >>> --- a/drivers/mfd/Kconfig >>> +++ b/drivers/mfd/Kconfig >>> @@ -425,14 +425,17 @@ config LPC_SCH >>> System Management Bus and General Purpose I/O. >>> >>> config INTEL_SOC_PMIC >>> - bool "Support for Intel Atom SoC PMIC" >>> + # This is a bool as it provides an ACPI Opregion which must >>> be >>> + # available as soon as possible >>> + bool "Support for Intel Crystal Cove PMIC" >>> depends on GPIOLIB >>> depends on I2C=y >>> select MFD_CORE >>> select REGMAP_I2C >>> select REGMAP_IRQ >>> + select I2C_DESIGNWARE_PLATFORM >>> help >>> - Select this option to enable support for the PMIC device >>> + Select this option to enable support for the Crystal Cove >>> PMIC >>> on some Intel SoC systems. The PMIC provides ADC, GPIO, >>> thermal, charger and related power management functions >>> on these systems. >> >