From: Joe Perches <joe@perches.com>
To: benniciemanuel78@gmail.com, linux-kernel@vger.kernel.org
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
Lukas Wunner <lukas@wunner.de>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Tyrel Datwyler <tyreld@linux.vnet.ibm.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH] pci: hotplug: ibmphp: Add white space to Debug Message
Date: Sun, 02 Jun 2019 09:16:57 -0700 [thread overview]
Message-ID: <16f2f9c2e34d59cdf9a7bf0f5111251c284e0a3b.camel@perches.com> (raw)
In-Reply-To: <20190602160007.24684-1-benniciemanuel78@gmail.com>
On Sun, 2019-06-02 at 18:00 +0200, Emanuel Bennici wrote:
> Add a Whitespace between '-' and 'Exit' to keep the log messages consistent
[]
> diff --git a/drivers/pci/hotplug/ibmphp_core.c b/drivers/pci/hotplug/ibmphp_core.c
[]
> @@ -890,7 +890,7 @@ static int set_bus(struct slot *slot_cur)
> /* This is for x440, once Brandon fixes the firmware,
> will not need this delay */
> msleep(1000);
> - debug("%s -Exit\n", __func__);
> + debug("%s - Exit\n", __func__);
These sorts of messages should just be deleted
and the function tracer (ftrace) used instead.
prev parent reply other threads:[~2019-06-02 16:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-02 16:00 Emanuel Bennici
2019-06-02 16:16 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16f2f9c2e34d59cdf9a7bf0f5111251c284e0a3b.camel@perches.com \
--to=joe@perches.com \
--cc=andy.shevchenko@gmail.com \
--cc=arnd@arndb.de \
--cc=benniciemanuel78@gmail.com \
--cc=bhelgaas@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=rafael.j.wysocki@intel.com \
--cc=tyreld@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®