From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBD0A41A77C for ; Thu, 16 Jul 2026 11:36:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784201772; cv=none; b=q1Kr7i8zCO0mqNJO+n8Lf3SUdiJd9zm1BK3M7/r583REHCglzdkp2RYM/3p5LrCZkaLeJS0pAirNRpRQOOxuXuMpEs6fh+WoC2c0cYxsf/QOf6yPXXc7ntjCzLLmCQEeCwqB2f9SVtCy8bECwEW8kX3ydJF+drRfwqRSJ2MjCXA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784201772; c=relaxed/simple; bh=zetSJ0c59ByWOy2eXS5poYreELcox54ZDL3f0xEL8w0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ODg2G7l/bNYLu28loUswDTPHv1fxkDAY7gBqv8GTVZdZ5Praj64SL1S6N1ZJtcvdtJc/LfleVYPnRyMswcpx+C/AkSc7q1JsJyz0Dq9p1DMGqYzR+xaHfSYs6YTjqR6y+WWHzVD+yhRffLkKLDeZGWJyHX+W1TfBhOsp0sw2iCk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QiQ5rI0e; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QiQ5rI0e" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-848882fdb18so3390909b3a.0 for ; Thu, 16 Jul 2026 04:36:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1784201769; x=1784806569; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=NS5iPB2mRTWBqt3tZiXGx3hLWOV6ZMr66GfCmNpO9k8=; b=QiQ5rI0eRFGxigFyJXsU8AJRJFGM+m1kwajLqIBu8QKY9W1T8CcjBgZbbFG7Zvubnz LjKwMXvSvyqBJXzFDuVpjG3EuYPLv6ckm8zYKMM3v+qbaL/jXBK9A/CyQjeApKIHNq2M xInFmKF5QSFAQGUyQ56Sdjvbl6Z2svlckcTjuavCn9cYBd6eIQFpmPCXyd8EJg505BKw r3HIsYIGk8f71xYJwhummZAqSwbVBcIOBOXrHohssS0nESIU6uhI/fBYcuZf5no5N0G1 Qs2qlf+IeN0bCMszcOMkIAEP73YQlGE1AkeSfXZ6aIIxdrBDFH0V112YvPWi3QLV0Yl5 Lfqg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784201769; x=1784806569; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=NS5iPB2mRTWBqt3tZiXGx3hLWOV6ZMr66GfCmNpO9k8=; b=iKM+DwyHKaATmRJLwS+HivtYbw5w1LWLYUr5O+S1y4D8su3LzJYZYcdQqDvUgAbnTi +7NN237Ij3Oq3G8o4GSFCIVyNbWEUrxJlzNOzXzAeflIporJJOhisBgve72gs264vsua bcyIDSne+wVQRw7h91/dvbDOal/a3IpU7/n6YmjeppJGT3amg8sIEvbL2mA5C5EmqSbL MgJJvcpWhJQ4V+sSLDA0ghKoJFAuhRESEHXNwMeZHTVmG2sEwYdlAlLN2h1CW76TQdSi DqpGM6xv5HMy1tiqkugO3XUV0Oyvvt2OXIqnyt1QjeD1t4wZbOqvZyfcHr1J/SQ+zr5s fIDQ== X-Gm-Message-State: AOJu0Ywl7qGigS7T6tG7pz1n7mpWhRuf4jq1VWBiWbvmTlVPBaP/0vB2 VVSf0AG0dQjAAhmePFdRckB8ed9rfOKvgebJOf6oj7AdNF4FeWmsXPw/ X-Gm-Gg: AfdE7clmLgIETPOCmfTkSydLFUEFnwRhO7IAoDCs0OSQFEeeTANNdMTfbtpLNswaeoC 6up/hYFJ1GMOQMkg3NrlD91wN0YGNFCSudl6sA3WQTkrvJ/zUIChIN489i9TRc5UpZwVdW/Qtng H5VxwfGULVMbq48oISgQtYOtvcW/5Wns8Csrj3KIWjXGqXMBRrb79IhzMYY5iPSDAsPCH9ZHaqH VtVITV6zRwq0bIaHB1aHlja2LsAUIaBxtWmcoiGrCgOYJ3pWHzRpgtuTNhPq183rwvhIWZsOsxs t6atkGndgDAH52Knt1xisw1W+iuiN9ush/y9lfzoshRbSghB3vLD7POyLYsMiqB6tpUuqtPXCwn K5oyC03R4otLBF2F4QhSf+SZqP32qdKUpfZJihxMhusI5YxpLw0LS8/qPgdN8CqPj39nJ6b27UF ABpJQdd9lsxvw3pqtZpiPMYwshMHEtB4J2Qd/A69PArXWYnnY71Hs= X-Received: by 2002:a05:6a20:158e:b0:3c0:b766:74f4 with SMTP id adf61e73a8af0-3c36c1f13cfmr6949530637.31.1784201769130; Thu, 16 Jul 2026 04:36:09 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13cd426b36asm9053465c88.2.2026.07.16.04.36.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Jul 2026 04:36:08 -0700 (PDT) Sender: Guenter Roeck Message-ID: <16f3837d-b416-4d5d-8876-4e08d5a9ef26@roeck-us.net> Date: Thu, 16 Jul 2026 04:36:06 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/8] Add Advantech EIO Hardware Monitor driver To: Ramiro Manuel Silva Oliveira , Lee Jones , Linus Walleij , Bartosz Golaszewski , Andi Shyti , Daniel Thompson , Jingoo Han , Helge Deller , Wim Van Sebroeck , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba Cc: "linux-kernel@vger.kernel.org" , "mfd@lists.linux.dev" , "linux-gpio@vger.kernel.org" , "linux-hwmon@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "linux-fbdev@vger.kernel.org" , "linux-watchdog@vger.kernel.org" , "linux-pm@vger.kernel.org" , "Wenkai.Chung" , Francisco Aragon-Trivino , Hongzhi Wang , Mikhail Tsukerman , "Thomas.Kastner" References: <20260714-upstream-v2-v2-0-76e5e41026db@advantech.com> <20260714-upstream-v2-v2-3-76e5e41026db@advantech.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 7/16/26 01:10, Ramiro Manuel Silva Oliveira wrote: >> On 7/14/26 08:54, Ramiro Oliveira wrote: >>> This driver controls the Hardware Monitor block of the Advantech EIO chip. >>> >>> There is a separate driver for the thermal device driver since it's a >>> use case we support currently, but if it's really necessary we can >>> move it to the same driver. >>> >>> Signed-off-by: Ramiro Oliveira >> >> Normally there would be a hwmon driver instantiating the thermal zone(s) >> using HWMON_C_REGISTER_TZ. If the driver actively controls thermal zones >> since it also handles fans, that would be instantiated from the hwmon driver. >> >> Since you have both thermal temperature and thermal fan drivers, I am very >> concerned that there is functionality overlap andor even conflicts. You should >> drop this driver and configure the thermal temperature driver to instantiate a >> hwmon device from it if so desired. > > But this hwmon driver doesn't control any setting, it just displays values. Fan > and Thermal Zone control is handled in the thermal fan and thermal > temperature drivers. > > Also this hwmon shows values not related to temperature, like voltage, > current and intrusion. > > Would it be ok if I kept the HW Monitor since it only displays values, and if > not can I keep it to show the other non-temperature values? > All other similar drivers implement a hwmon driver and instantiate the thermal subsystem from it. You decided to implement thermal drivers. You should only have thermal or hwmon drivers, not both. Having both would essentially implement two drivers with overlapping functionality. Since you decided that you want separate thermal drivers, and two of them, you should drop the hwmon driver. Guenter