mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Axel Lin'" <axel.lin@ingics.com>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	"'John Stultz'" <john.stultz@linaro.org>
Cc: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
	"'Changhwan Youn'" <chaos.youn@samsung.com>,
	linux-kernel@vger.kernel.org
Subject: RE: [PATCH] clocksource: exynos_mct: Add terminating entry for exynos_mct_ids table
Date: Mon, 25 Mar 2013 10:11:47 +0900	[thread overview]
Message-ID: <16f801ce28f5$b9095c20$2b1c1460$%kim@samsung.com> (raw)
In-Reply-To: <1364048887.13141.0.camel@phoenix>

Axel Lin wrote:
> 
> The of_device_id table is supposed to be zero-terminated.
> 
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
>  drivers/clocksource/exynos_mct.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/clocksource/exynos_mct.c
> b/drivers/clocksource/exynos_mct.c
> index 203ac05..3cdafc0 100644
> --- a/drivers/clocksource/exynos_mct.c
> +++ b/drivers/clocksource/exynos_mct.c
> @@ -514,6 +514,7 @@ static void __init exynos4_timer_resources(struct
> device_node *np)
>  static const struct of_device_id exynos_mct_ids[] = {
>  	{ .compatible = "samsung,exynos4210-mct", .data = (void
> *)MCT_INT_SPI },
>  	{ .compatible = "samsung,exynos4412-mct", .data = (void
> *)MCT_INT_PPI },
> +	{ }

Thanks for your pointing out. But as I know, it is not mandatory now.

Please correct me if I'm wrong.

Thanks.

- Kukjin


  reply	other threads:[~2013-03-25  1:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-23 14:28 Axel Lin
2013-03-25  1:11 ` Kukjin Kim [this message]
2013-03-25  1:18   ` Axel Lin
2013-03-25 10:13     ` Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='16f801ce28f5$b9095c20$2b1c1460$%kim@samsung.com' \
    --to=kgene.kim@samsung.com \
    --cc=axel.lin@ingics.com \
    --cc=chaos.youn@samsung.com \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thomas.abraham@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®