From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753748AbdG2MoF (ORCPT ); Sat, 29 Jul 2017 08:44:05 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:41789 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753288AbdG2MoD (ORCPT ); Sat, 29 Jul 2017 08:44:03 -0400 Subject: Re: [PATCH] tinydrm: repaper: add CONFIG_THERMAL dependency To: Arnd Bergmann , David Airlie Cc: Thierry Reding , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20170727100004.300665-1-arnd@arndb.de> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <16f88019-6130-8f78-211a-1d26fc8a21f6@tronnes.org> Date: Sat, 29 Jul 2017 14:43:48 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170727100004.300665-1-arnd@arndb.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Den 27.07.2017 11.58, skrev Arnd Bergmann: > The new RePaper driver uses the thermal subsystem, and fails to link > when it is built-in but thermal is a loadable module: > > drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_probe': > repaper.c:(.text+0x540): undefined reference to `thermal_zone_get_zone_by_name' > drivers/gpu/drm/tinydrm/repaper.o: In function `repaper_fb_dirty': > repaper.c:(.text+0xff4): undefined reference to `thermal_zone_get_temp' > > This adds another Kconfig dependency to prevent the broken configuration, > forcing repaper to be a module too. > > Fixes: 3589211e9b03 ("drm/tinydrm: Add RePaper e-ink driver") > Signed-off-by: Arnd Bergmann > --- Thanks for fixing this, applied to drm-misc. Noralf. > drivers/gpu/drm/tinydrm/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/tinydrm/Kconfig b/drivers/gpu/drm/tinydrm/Kconfig > index 9596e447f877..f17c3caceab2 100644 > --- a/drivers/gpu/drm/tinydrm/Kconfig > +++ b/drivers/gpu/drm/tinydrm/Kconfig > @@ -23,6 +23,7 @@ config TINYDRM_MI0283QT > config TINYDRM_REPAPER > tristate "DRM support for Pervasive Displays RePaper panels (V231)" > depends on DRM_TINYDRM && SPI > + depends on THERMAL || !THERMAL > help > DRM driver for the following Pervasive Displays panels: > 1.44" TFT EPD Panel (E1144CS021)