From: Mikael Pettersson <mikpe@user.it.uu.se>
To: ak@suse.de, marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.4.31-pre1] x86_64 breakage on UP_IOAPIC
Date: Tue, 26 Apr 2005 21:58:22 +0200 [thread overview]
Message-ID: <17006.40286.664503.252615@alkaid.it.uu.se> (raw)
The
o x86_64: Resend lost APIC IRQs on Uniprocessor too
change in 2.4.31-pre1 causes linkage errors: on UP_IOAPIC systems it
creates references to send_IPI_self() which is only defined on SMP.
The patch below reverts this change.
Alternatively, x86_64 could implement a send_IPI_self() fallback for !SMP,
just like i386 does.
/Mikael
--- linux-2.4.31-pre1/include/asm-x86_64/hw_irq.h.~1~ 2005-04-26 20:57:43.000000000 +0200
+++ linux-2.4.31-pre1/include/asm-x86_64/hw_irq.h 2005-04-26 21:09:31.000000000 +0200
@@ -156,7 +156,7 @@ static inline void x86_do_profile (unsig
atomic_inc((atomic_t *)&prof_buffer[eip]);
}
-#ifdef CONFIG_X86_IO_APIC
+#ifdef CONFIG_SMP /*more of this file should probably be ifdefed SMP */
static inline void hw_resend_irq(struct hw_interrupt_type *h, unsigned int i) {
if (IO_APIC_IRQ(i))
send_IPI_self(IO_APIC_VECTOR(i));
next reply other threads:[~2005-04-26 19:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 19:58 Mikael Pettersson [this message]
2005-04-26 22:19 ` Jesper Juhl
2005-04-26 22:19 ` Mikael Pettersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17006.40286.664503.252615@alkaid.it.uu.se \
--to=mikpe@user.it.uu.se \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®