From: Mikael Pettersson <mikpe@user.it.uu.se>
To: akpm@osdl.org, marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.4.31-pre1] rwsem-spinlock linkage error
Date: Tue, 26 Apr 2005 22:04:10 +0200 [thread overview]
Message-ID: <17006.40634.550626.473965@alkaid.it.uu.se> (raw)
The
Andrew Morton:
o rwsem: Make rwsems use interrupt disabling spinlocks
change in 2.4.31-pre1 has a typo: one occurrence of spin_unlock() was
changed to spin_unlock_restore() instead of spin_unlock_irqrestore()
as was obviously the intention. Since spin_unlock_restore() doesn't
exist, this results in linkage errors on x86_64 and other archs using
CONFIG_RWSEM_GENERIC_SPINLOCK.
Trival fix below.
Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
--- linux-2.4.31-pre1/lib/rwsem-spinlock.c.~1~ 2005-04-26 19:12:52.000000000 +0200
+++ linux-2.4.31-pre1/lib/rwsem-spinlock.c 2005-04-26 21:16:05.000000000 +0200
@@ -269,7 +269,7 @@ void fastcall __up_read(struct rw_semaph
if (--sem->activity==0 && !list_empty(&sem->wait_list))
sem = __rwsem_wake_one_writer(sem);
- spin_unlock_restore(&sem->wait_lock, flags);
+ spin_unlock_irqrestore(&sem->wait_lock, flags);
rwsemtrace(sem,"Leaving __up_read");
}
next reply other threads:[~2005-04-26 20:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-26 20:04 Mikael Pettersson [this message]
2005-04-27 15:28 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17006.40634.550626.473965@alkaid.it.uu.se \
--to=mikpe@user.it.uu.se \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®