From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: devicetree@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
moderated list: ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
<linux-arm-kernel@lists.infradead.org>,
open list <linux-kernel@vger.kernel.org>, ;
Subject: Re: [PATCH v2] arm64: dts: freescale: debix-som-a-bmb-08: Add CSI Power Regulators
Date: Mon, 27 Nov 2023 11:27:43 +0000 [thread overview]
Message-ID: <170108446363.451646.11141020197161463231@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20231127025706.GT87953@dragon>
Quoting Shawn Guo (2023-11-27 02:57:06)
> On Wed, Nov 01, 2023 at 10:46:11AM +0000, Kieran Bingham wrote:
> > Provide the 1.8 and 3.3 volt regulators that are utilised on the Debix
> > SOM BMB-08 base board.
> >
> > Facilitate this by also supplying the pin control used to enable the
> > regulators on the second MIPI CSI port.
> >
> > Reviewed-by: Marco Felsch <m.felsch@pengutronix.de>
> > Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
> >
> > ---
> > v2:
> > - Remove _SW post fixes from regulators.
> >
> > .../freescale/imx8mp-debix-som-a-bmb-08.dts | 56 +++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> > index 0b0c95432bdc..386177c66c6d 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-debix-som-a-bmb-08.dts
> > @@ -63,6 +63,50 @@ regulator-som-vdd3v3 {
> > regulator-always-on;
> > };
> >
> > + reg_csi1_1v8: regulator-csi1-vdd1v8 {
> > + compatible = "regulator-fixed";
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-name = "CSI1_VDD1V8";
> > + gpio = <&expander0 13 GPIO_ACTIVE_HIGH>;
> > + vin-supply = <®_baseboard_vdd3v3>;
> > + enable-active-high;
>
> Could you move it one line above, so that it appears right after
> GPIO_ACTIVE_HIGH polarity?
Yes, Sorry - I'm not sure why this is inconsistent with all the others.
v3 heading out next.
--
Kieran
>
> Shawn
>
> > + };
> > +
> > + reg_csi1_3v3: regulator-csi1-vdd3v3 {
> > + compatible = "regulator-fixed";
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "CSI1_VDD3V3";
> > + gpio = <&expander0 14 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + vin-supply = <®_vdd5v0>;
> > + };
> > +
> > + reg_csi2_1v8: regulator-csi2-vdd1v8 {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_reg_csi2_1v8>;
> > + regulator-min-microvolt = <1800000>;
> > + regulator-max-microvolt = <1800000>;
> > + regulator-name = "CSI2_VDD1V8";
> > + gpio = <&gpio3 21 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + vin-supply = <®_baseboard_vdd3v3>;
> > + };
> > +
> > + reg_csi2_3v3: regulator-csi2-vdd3v3 {
> > + compatible = "regulator-fixed";
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&pinctrl_reg_csi2_3v3>;
> > + regulator-min-microvolt = <3300000>;
> > + regulator-max-microvolt = <3300000>;
> > + regulator-name = "CSI2_VDD3V3";
> > + gpio = <&gpio4 25 GPIO_ACTIVE_HIGH>;
> > + enable-active-high;
> > + vin-supply = <®_vdd5v0>;
> > + };
> > +
> > regulator-vbus-usb20 {
> > compatible = "regulator-fixed";
> > regulator-min-microvolt = <5000000>;
> > @@ -413,6 +457,18 @@ MX8MP_IOMUXC_GPIO1_IO03__GPIO1_IO03 0x41
> > >;
> > };
> >
> > + pinctrl_reg_csi2_1v8: regcsi21v8grp {
> > + fsl,pins = <
> > + MX8MP_IOMUXC_SAI5_RXD0__GPIO3_IO21 0x19
> > + >;
> > + };
> > +
> > + pinctrl_reg_csi2_3v3: regcsi23v3grp {
> > + fsl,pins = <
> > + MX8MP_IOMUXC_SAI2_TXC__GPIO4_IO25 0x19
> > + >;
> > + };
> > +
> > pinctrl_uart2: uart2grp {
> > fsl,pins = <
> > MX8MP_IOMUXC_UART2_RXD__UART2_DCE_RX 0x14f
> > --
> > 2.34.1
> >
prev parent reply other threads:[~2023-11-27 11:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 10:46 Kieran Bingham
2023-11-27 2:57 ` Shawn Guo
2023-11-27 11:27 ` Kieran Bingham [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170108446363.451646.11141020197161463231@ping.linuxembedded.co.uk \
--to=kieran.bingham@ideasonboard.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®