From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1FD3C10F07 for ; Wed, 6 Dec 2023 13:10:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1378430AbjLFNKR (ORCPT ); Wed, 6 Dec 2023 08:10:17 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44766 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1378414AbjLFNKO (ORCPT ); Wed, 6 Dec 2023 08:10:14 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8ABAB1A5 for ; Wed, 6 Dec 2023 05:10:20 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CE206C433C8; Wed, 6 Dec 2023 13:10:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701868220; bh=h9KWpohyTTR3pTq0NasEcVnQ4d28IL9h85MEdUeIIK0=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=EPvHc7hY/n7aNn4K0+fbS9tNtpE4h3wneK9nI/9mhJZtawvSq6BdhQYu2mMnimYaT 8L9nhgbracmjU6JuMzv8Mc5JksS5UYPnSXlvW481bxAVtaKuVzlVG0BG0jB/HX5ZiZ O/fgZsW12TkNt7P/zT/gREKO3uMn0FwteP9SfGGGP8/2+Scr2xQGE0oMwfM9gNBgY9 c8/PO8qgnkJFdivu6dl2kqLjpQSny1wFq8Sp1yPUEBrRDTe3W8IVzhdy5aN/LGf/vy XJPr6IELbXQjivPkFk8TVp3dcnEXwzAV7UHXMVw1aQ3V56kSjBzg5zldiyaWOzJ0h5 6+Up6o37toN1g== From: Maxime Ripard To: Frank Binns , Donald Robson , Matt Coster , Maarten Lankhorst , Sarah Walker , Arnd Bergmann Cc: Arnd Bergmann , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: <20231204073231.1164163-1-arnd@kernel.org> References: <20231204073231.1164163-1-arnd@kernel.org> Subject: Re: (subset) [PATCH] drm/imagination: move update_logtype() into ifdef section Message-Id: <170186821781.357447.7620047835600780144.b4-ty@kernel.org> Date: Wed, 06 Dec 2023 14:10:17 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 04 Dec 2023 08:32:10 +0100, Arnd Bergmann wrote: > This function is only used when debugfs is enabled, and otherwise > causes a build warning: > > drivers/gpu/drm/imagination/pvr_fw_trace.c:135:1: error: 'update_logtype' defined but not used [-Werror=unused-function] > > Move the #ifdef check to include this function as well. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime