From: Bjorn Andersson <andersson@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "Arnd Bergmann" <arnd@arndb.de>, "Andy Gross" <agross@kernel.org>,
"Konrad Dybcio" <konrad.dybcio@linaro.org>,
"Stephen Boyd" <swboyd@chromium.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: (subset) [PATCH 1/2] soc: qcom: stats: fix 64-bit division
Date: Fri, 8 Dec 2023 06:55:14 -0800 [thread overview]
Message-ID: <170204733604.342318.17962213281334041105.b4-ty@kernel.org> (raw)
In-Reply-To: <20231206123717.524009-1-arnd@kernel.org>
On Wed, 06 Dec 2023 13:37:06 +0100, Arnd Bergmann wrote:
> Unguarded 64-bit division is not allowed on 32-bit kernels because this
> is very slow. The result of trying anyway is a link failure:
>
> arm-linux-gnueabi-ld: drivers/soc/qcom/qcom_stats.o: in function `qcom_ddr_stats_show':
> qcom_stats.c:(.text+0x334): undefined reference to `__aeabi_uldivmod'
>
> As this function is only used for debugging and not performance critical,
> rewrite it to use div_u64() instead. ARCH_TIMER_FREQ is a multiple of
> MSEC_PER_SEC anyway, so there is no loss in precisison.
>
> [...]
Applied, thanks!
[1/2] soc: qcom: stats: fix 64-bit division
commit: 73380e2573c34a45e01786750a4a2efafc2248bd
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2023-12-08 14:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-06 12:37 Arnd Bergmann
2023-12-06 12:37 ` [PATCH 2/2] soc: qcom_stats: add AOSS_QMP dependency Arnd Bergmann
2023-12-06 14:16 ` [PATCH 1/2] soc: qcom: stats: fix 64-bit division Uwe Kleine-König
2023-12-07 15:24 ` Bjorn Andersson
2023-12-08 14:55 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170204733604.342318.17962213281334041105.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=agross@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=swboyd@chromium.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®