From: Rob Herring <robh@kernel.org>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Vinod Koul <vkoul@kernel.org>, John Crispin <john@phrozen.org>,
Andrew Lunn <andrew@lunn.ch>, Rob Herring <robh+dt@kernel.org>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
devicetree@vger.kernel.org, Alexander Couzens <lynxis@fe80.eu>,
netdev@vger.kernel.org, Chunfeng Yun <chunfeng.yun@mediatek.com>,
SkyLake Huang <SkyLake.Huang@mediatek.com>,
Sean Wang <sean.wang@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
Qingfang Deng <dqfext@gmail.com>,
Russell King <linux@armlinux.org.uk>,
Philipp Zabel <p.zabel@pengutronix.de>,
Paolo Abeni <pabeni@redhat.com>, Jakub Kicinski <kuba@kernel.org>,
Felix Fietkau <nbd@nbd.name>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-mediatek@lists.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Kishon Vijay Abraham I <kishon@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [RFC PATCH net-next v3 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes
Date: Mon, 11 Dec 2023 23:43:35 -0600 [thread overview]
Message-ID: <170235981509.39662.6730294984307830032.robh@kernel.org> (raw)
In-Reply-To: <5859da6629b8b6c100eca4062dd193105bf829ba.1702352117.git.daniel@makrotopia.org>
On Tue, 12 Dec 2023 03:48:10 +0000, Daniel Golle wrote:
> Several clocks as well as both sgmiisys phandles were added by mistake
> to the Ethernet bindings for MT7988.
>
> This happened because the vendor driver which served as a reference
> uses a high number of syscon phandles to access various parts of the
> SoC which wasn't acceptable upstream. Hence several parts which have
> never previously been supported (such SerDes PHY and USXGMII PCS) have
> been moved to separate drivers which also result in a much more sane
> device tree.
>
> Quickly align the bindings with the upcoming reality of the drivers
> actually adding full support for this SoC.
>
> Fixes: c94a9aabec36 ("dt-bindings: net: mediatek,net: add mt7988-eth binding")
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
> ---
> .../devicetree/bindings/net/mediatek,net.yaml | 32 ++++---------------
> 1 file changed, 7 insertions(+), 25 deletions(-)
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/net/pcs/mediatek,usxgmii.example.dts:18:18: fatal error: dt-bindings/clock/mediatek,mt7988-clk.h: No such file or directory
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/net/pcs/mediatek,usxgmii.example.dtb] Error 1
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/5859da6629b8b6c100eca4062dd193105bf829ba.1702352117.git.daniel@makrotopia.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-12-12 5:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 3:45 [RFC PATCH net-next v3 0/8] Add support for 10G Ethernet SerDes on MT7988 Daniel Golle
2023-12-12 3:46 ` [RFC PATCH net-next v3 1/8] dt-bindings: phy: mediatek,xfi-pextp: add new bindings Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:21 ` Conor Dooley
2023-12-12 16:42 ` Daniel Golle
2023-12-13 9:46 ` Conor Dooley
2023-12-13 13:20 ` Andrew Lunn
2023-12-16 1:16 ` Daniel Golle
2023-12-12 3:46 ` [RFC PATCH net-next v3 2/8] phy: add driver for MediaTek pextp 10GE SerDes PHY Daniel Golle
2023-12-12 10:41 ` AngeloGioacchino Del Regno
2023-12-13 2:13 ` Chunfeng Yun (云春峰)
2023-12-21 16:48 ` Vinod Koul
2023-12-12 3:47 ` [RFC PATCH net-next v3 3/8] net: pcs: pcs-mtk-lynxi: add platform driver for MT7988 Daniel Golle
2023-12-13 16:04 ` Russell King (Oracle)
2024-02-07 1:29 ` Daniel Golle
2024-04-22 16:23 ` Daniel Golle
2024-07-10 11:17 ` Frank Wunderlich
2024-10-04 14:17 ` Aw: " Frank Wunderlich
2024-10-04 14:35 ` Russell King (Oracle)
2025-01-05 11:29 ` Aw: " Frank Wunderlich
2023-12-12 3:47 ` [RFC PATCH net-next v3 4/8] dt-bindings: net: pcs: add bindings for MediaTek USXGMII PCS Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:24 ` Conor Dooley
2023-12-12 3:47 ` [RFC PATCH net-next v3 5/8] net: pcs: add driver " Daniel Golle
2023-12-12 9:29 ` Simon Horman
2023-12-12 3:48 ` [RFC PATCH net-next v3 6/8] dt-bindings: net: mediatek: remove wrongly added clocks and SerDes Daniel Golle
2023-12-12 5:43 ` Rob Herring [this message]
2023-12-12 16:29 ` Conor Dooley
2023-12-12 3:51 ` [RFC PATCH net-next v3 7/8] dt-bindings: net: mediatek,net: fix and complete mt7988-eth binding Daniel Golle
2023-12-12 5:43 ` Rob Herring
2023-12-12 16:34 ` Conor Dooley
2023-12-13 6:58 ` Krzysztof Kozlowski
2023-12-12 3:51 ` [RFC PATCH net-next v3 8/8] net: ethernet: mtk_eth_soc: add paths and SerDes modes for MT7988 Daniel Golle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170235981509.39662.6730294984307830032.robh@kernel.org \
--to=robh@kernel.org \
--cc=Mark-MC.Lee@mediatek.com \
--cc=SkyLake.Huang@mediatek.com \
--cc=andrew@lunn.ch \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=conor+dt@kernel.org \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=john@phrozen.org \
--cc=kishon@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=lorenzo@kernel.org \
--cc=lynxis@fe80.eu \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=sean.wang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®