From: Kalle Valo <kvalo@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Arnd Bergmann <arnd@arndb.de>, Ching-Te Ku <ku920601@realtek.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: wifi: rtw89: avoid stringop-overflow warning
Date: Tue, 12 Dec 2023 15:11:11 +0000 (UTC) [thread overview]
Message-ID: <170239387004.306086.15470071247075562655.kvalo@kernel.org> (raw)
In-Reply-To: <20231204073020.1105416-1-arnd@kernel.org>
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> After -Wstringop-overflow got enabled, the rtw89 driver produced
> two odd warnings with gcc-13:
>
> drivers/net/wireless/realtek/rtw89/coex.c: In function 'rtw89_btc_ntfy_scan_start':
> drivers/net/wireless/realtek/rtw89/coex.c:5362:50: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
> 5362 | wl->dbcc_info.scan_band[phy_idx] = band;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> In file included from drivers/net/wireless/realtek/rtw89/coex.h:8,
> from drivers/net/wireless/realtek/rtw89/coex.c:5:
> drivers/net/wireless/realtek/rtw89/core.h:1441:12: note: at offset [64, 255] into destination object 'scan_band' of size 2
> 1441 | u8 scan_band[RTW89_PHY_MAX]; /* scan band in each phy */
> | ^~~~~~~~~
> drivers/net/wireless/realtek/rtw89/coex.c: In function 'rtw89_btc_ntfy_switch_band':
> drivers/net/wireless/realtek/rtw89/coex.c:5406:50: error: writing 1 byte into a region of size 0 [-Werror=stringop-overflow=]
> 5406 | wl->dbcc_info.scan_band[phy_idx] = band;
> | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~
> drivers/net/wireless/realtek/rtw89/core.h:1441:12: note: at offset [64, 255] into destination object 'scan_band' of size 2
> 1441 | u8 scan_band[RTW89_PHY_MAX]; /* scan band in each phy */
> | ^~~~~~~~~
>
> I don't know what happened here, but adding an explicit range check
> shuts up the output.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Patch applied to wireless-next.git, thanks.
595b1280e2c9 wifi: rtw89: avoid stringop-overflow warning
--
https://patchwork.kernel.org/project/linux-wireless/patch/20231204073020.1105416-1-arnd@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2023-12-12 15:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 7:30 [PATCH] " Arnd Bergmann
2023-12-05 0:26 ` Ping-Ke Shih
2023-12-07 15:47 ` Kalle Valo
2023-12-07 16:11 ` Arnd Bergmann
2023-12-12 14:23 ` Kalle Valo
2023-12-12 15:11 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170239387004.306086.15470071247075562655.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=gustavoars@kernel.org \
--cc=ku920601@realtek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®