From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18087C4167D for ; Wed, 13 Dec 2023 15:22:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1442512AbjLMPWf (ORCPT ); Wed, 13 Dec 2023 10:22:35 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38544 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1442482AbjLMPWc (ORCPT ); Wed, 13 Dec 2023 10:22:32 -0500 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67D55F3 for ; Wed, 13 Dec 2023 07:22:39 -0800 (PST) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 945C5C433C7; Wed, 13 Dec 2023 15:22:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1702480959; bh=g9AfdMsMWQPrTFn3Rfxxtm16T5CwU3D5GqboUlkSxB8=; h=From:To:Cc:In-Reply-To:References:Subject:Date:From; b=GDrZI2XBTh3hJVVSXnxYxcQ4Ww8ny4IzmGeEg2lCyPdTBuIsmFvcdHOOWb3OtN+sK Tois1SqVzSuh4dUcqTnrm6GeKSz2YO2M+zSACcHSe0kaK2xIDt21NRwR5vhw9AFhaN oOWOyxDTSykwywZ7/ug2xhYAC1x58VCuQkgHji75L/2zZdCu9wGzUx+m0hLEdOnjty MR9/mY93zS4jpNKKATj/S1wq7Lv2Qdto6ywA3JCiSKgGgLTyPgGohLQ0YcKBw1GjxE 62s77VFc1bViQj0yc3xnuDiL9x+2Jp0315SB85Qy+InXIFG9zFEPAYk4JOu/zZBjJA n9F+eN/wC2Dmw== From: Maxime Ripard To: Frank Binns , Donald Robson , Matt Coster , Maarten Lankhorst , Thomas Zimmermann , Alex Bee Cc: David Airlie , Daniel Vetter , Sarah Walker , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org In-Reply-To: <20231208170856.1748413-1-knaerzche@gmail.com> References: <20231208170856.1748413-1-knaerzche@gmail.com> Subject: Re: (subset) [PATCH] drm/imagination: vm: Fix heap lookup condition Message-Id: <170248095546.191897.14747854434891174089.b4-ty@kernel.org> Date: Wed, 13 Dec 2023 16:22:35 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.3 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 08 Dec 2023 18:08:56 +0100, Alex Bee wrote: > When conditionally checking for heap existence of a certian address in > pvr_vm_bind_op_map_init the condition whether the map request comes from a > user is incorrect: The context must not be the kernel-context to be a > user(space) context and should be looked up in pvr_heaps. > > That makes addresses coming from userspace not being verfied against the > defined ranges and prevents firmware loading for meta cores. > > [...] Applied to drm/drm-misc (drm-misc-next). Thanks! Maxime