From: Mikael Pettersson <mikpe@user.it.uu.se>
To: marcelo.tosatti@cyclades.com, ak@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 2.4.31-pre2] x86_64 linkage error on UP_IOAPIC
Date: Fri, 13 May 2005 10:33:31 +0200 [thread overview]
Message-ID: <17028.26204.8545.584415@alkaid.it.uu.se> (raw)
When 2.4.31-pre2 is configured for X86_64 && !SMP && UP_IOAPIC
it fails to link:
arch/x86_64/kernel/kernel.o(.text+0x4591): In function `enable_irq':
: undefined reference to `send_IPI_self'
make: *** [vmlinux] Error 1
A broken change in 2.4.31-pre{1,2} made the UP kernel reference
a symbol which is only defined in the SMP kernel.
The patch below fixes this by reverting that change.
Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
diff -rupN linux-2.4.31-pre2/include/asm-x86_64/hw_irq.h linux-2.4.31-pre2.x86_64-fix/include/asm-x86_64/hw_irq.h
--- linux-2.4.31-pre2/include/asm-x86_64/hw_irq.h 2005-05-13 00:05:51.000000000 +0200
+++ linux-2.4.31-pre2.x86_64-fix/include/asm-x86_64/hw_irq.h 2005-05-13 00:35:59.000000000 +0200
@@ -156,7 +156,7 @@ static inline void x86_do_profile (unsig
atomic_inc((atomic_t *)&prof_buffer[eip]);
}
-#ifdef CONFIG_X86_IO_APIC
+#ifdef CONFIG_SMP /*more of this file should probably be ifdefed SMP */
static inline void hw_resend_irq(struct hw_interrupt_type *h, unsigned int i) {
if (IO_APIC_IRQ(i))
send_IPI_self(IO_APIC_VECTOR(i));
reply other threads:[~2005-05-13 8:34 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17028.26204.8545.584415@alkaid.it.uu.se \
--to=mikpe@user.it.uu.se \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®