mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Karel Balej <karelb@gimli.ms.mff.cuni.cz>
Cc: linux-input@vger.kernel.org, "Karel Balej" <balejk@matfyz.cz>,
	"Lee Jones" <lee@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	phone-devel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	~postmarketos/upstreaming@lists.sr.ht,
	"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
	"Duje Mihanović" <duje.mihanovic@skole.hr>
Subject: Re: [RFC PATCH 1/5] dt-bindings: mfd: add entry for the Marvell 88PM88X PMICs
Date: Sun, 17 Dec 2023 08:24:42 -0600	[thread overview]
Message-ID: <170282308150.876352.2264944400902507705.robh@kernel.org> (raw)
In-Reply-To: <20231217131838.7569-2-karelb@gimli.ms.mff.cuni.cz>


On Sun, 17 Dec 2023 14:16:59 +0100, Karel Balej wrote:
> From: Karel Balej <balejk@matfyz.cz>
> 
> Marvell 88PM880 and 88PM886 are two similar PMICs with mostly matching
> register mapping and subdevices such as onkey, regulators or battery and
> charger. Both seem to come in two revisions which seem to be handled
> slightly differently in some subdevice drivers.
> 
> Signed-off-by: Karel Balej <balejk@matfyz.cz>
> ---
>  .../bindings/mfd/marvell,88pm88x.yaml         | 55 +++++++++++++++++++
>  1 file changed, 55 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/marvell,88pm88x.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/mfd/marvell,88pm88x.example.dts:30.31-32 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/mfd/marvell,88pm88x.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231217131838.7569-2-karelb@gimli.ms.mff.cuni.cz

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2023-12-17 14:24 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-17 13:16 [RFC PATCH 0/5] support for Marvell 88PM886 PMIC Karel Balej
2023-12-17 13:16 ` [RFC PATCH 1/5] dt-bindings: mfd: add entry for the Marvell 88PM88X PMICs Karel Balej
2023-12-17 14:24   ` Rob Herring [this message]
2023-12-18 15:17   ` Rob Herring
2023-12-22 17:25     ` Karel Balej
2023-12-17 13:17 ` [RFC PATCH 2/5] mfd: add 88pm88x driver Karel Balej
2024-01-25 12:26   ` Lee Jones
2024-01-28  9:38     ` Karel Balej
2024-01-31 11:03       ` Lee Jones
2024-02-01 15:37         ` Karel Balej
2024-02-02 12:45           ` Lee Jones
2024-02-02 12:55             ` Karel Balej
2024-02-02 13:29               ` Lee Jones
2023-12-17 13:17 ` [RFC PATCH 3/5] dt-bindings: input: add entry for 88pm88x-onkey Karel Balej
2023-12-17 14:24   ` Rob Herring
2023-12-18 15:18   ` Rob Herring
2023-12-17 13:17 ` [RFC PATCH 4/5] input: add onkey driver for Marvell 88PM88X PMICs Karel Balej
2023-12-20 23:33   ` Dmitry Torokhov
2023-12-17 13:17 ` [RFC PATCH 5/5] MAINTAINERS: add myself " Karel Balej

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170282308150.876352.2264944400902507705.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=balejk@matfyz.cz \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=duje.mihanovic@skole.hr \
    --cc=karelb@gimli.ms.mff.cuni.cz \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®