From: Rob Herring <robh@kernel.org>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Conor Dooley" <conor+dt@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
devicetree@vger.kernel.org, "Rafał Miłecki" <rafal@milecki.pl>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Miquel Raynal" <miquel.raynal@bootlin.com>,
linux-mtd@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
"Michael Walle" <michael@walle.cc>,
linux-kernel@vger.kernel.org,
"Srinivas Kandagatla" <srinivas.kandagatla@linaro.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
u-boot@lists.denx.de
Subject: Re: [PATCH 1/4] dt-bindings: nvmem: layouts: add U-Boot environment variables layout
Date: Mon, 18 Dec 2023 08:48:32 -0600 [thread overview]
Message-ID: <170291091219.3792434.8389294947030479112.robh@kernel.org> (raw)
In-Reply-To: <20231218133722.16150-1-zajec5@gmail.com>
On Mon, 18 Dec 2023 14:37:19 +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> U-Boot env data is a way of storing firmware variables. It's a format
> that can be used of top of various storage devices. Its binding should
> be an NVMEM layout instead of a standalone device.
>
> This patch adds layout binding which allows using it on top of MTD NVMEM
> device as well as any other. At the same time it deprecates the old
> combined binding.
>
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
> .../bindings/nvmem/layouts/u-boot,env.yaml | 55 +++++++++++++++++++
> .../devicetree/bindings/nvmem/u-boot,env.yaml | 6 ++
> 2 files changed, 61 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/nvmem/layouts/u-boot,env.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/u-boot,env.example.dtb: partition@40000: 'ethaddr', 'reg' do not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/nvmem/layouts/u-boot,env.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/nvmem/u-boot,env.example.dtb: partition-u-boot-env: 'ethaddr' does not match any of the regexes: 'pinctrl-[0-9]+'
from schema $id: http://devicetree.org/schemas/nvmem/layouts/u-boot,env.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20231218133722.16150-1-zajec5@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
next prev parent reply other threads:[~2023-12-18 14:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-18 13:37 Rafał Miłecki
2023-12-18 13:37 ` [PATCH 2/4] nvmem: core: add nvmem_dev_size() helper Rafał Miłecki
2023-12-18 14:03 ` Miquel Raynal
2023-12-18 13:37 ` [PATCH 3/4] nvmem: u-boot-env: use more nvmem subsystem helpers Rafał Miłecki
2023-12-18 14:02 ` Miquel Raynal
2023-12-18 13:37 ` [PATCH 4/4] nvmem: layouts: add U-Boot env layout Rafał Miłecki
2023-12-18 14:21 ` Miquel Raynal
2023-12-18 22:10 ` Rafał Miłecki
2023-12-19 7:55 ` Miquel Raynal
2023-12-19 9:55 ` Rafał Miłecki
2023-12-19 10:10 ` Rafał Miłecki
2023-12-18 14:48 ` Rob Herring [this message]
2023-12-18 22:13 ` [PATCH 1/4] dt-bindings: nvmem: layouts: add U-Boot environment variables layout Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170291091219.3792434.8389294947030479112.robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael@walle.cc \
--cc=miquel.raynal@bootlin.com \
--cc=rafal@milecki.pl \
--cc=robh+dt@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=u-boot@lists.denx.de \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®