mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Anna-Maria Behnsen" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: "Anna-Maria Behnsen" <anna-maria@linutronix.de>,
	Thomas Gleixner <tglx@linutronix.de>,
	Frederic Weisbecker <frederic@kernel.org>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/core] timers: Split out forward timer base functionality
Date: Wed, 20 Dec 2023 15:59:07 -0000	[thread overview]
Message-ID: <170308794724.398.14686394808339432944.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20231201092654.34614-10-anna-maria@linutronix.de>

The following commit has been merged into the timers/core branch of tip:

Commit-ID:     1e490484aa3af42d4eeffabf96d6a02be69d586b
Gitweb:        https://git.kernel.org/tip/1e490484aa3af42d4eeffabf96d6a02be69d586b
Author:        Anna-Maria Behnsen <anna-maria@linutronix.de>
AuthorDate:    Fri, 01 Dec 2023 10:26:31 +01:00
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Wed, 20 Dec 2023 16:49:38 +01:00

timers: Split out forward timer base functionality

Forwarding timer base is done when the next expiry value is calculated and
when a new timer is enqueued. When the next expiry value is calculated the
jiffies value is already available and does not need to be reread a second
time.

Splitting out the forward timer base functionality to make it executable
via both contextes - those where jiffies are already known and those, where
jiffies need to be read.

No functional change.

Signed-off-by: Anna-Maria Behnsen <anna-maria@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Frederic Weisbecker <frederic@kernel.org>
Link: https://lore.kernel.org/r/20231201092654.34614-10-anna-maria@linutronix.de

---
 kernel/time/timer.c | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)

diff --git a/kernel/time/timer.c b/kernel/time/timer.c
index f75f932..5b02e16 100644
--- a/kernel/time/timer.c
+++ b/kernel/time/timer.c
@@ -939,30 +939,34 @@ get_target_base(struct timer_base *base, unsigned tflags)
 	return get_timer_this_cpu_base(tflags);
 }
 
-static inline void forward_timer_base(struct timer_base *base)
+static inline void __forward_timer_base(struct timer_base *base,
+					unsigned long basej)
 {
-	unsigned long jnow = READ_ONCE(jiffies);
-
 	/*
 	 * Check whether we can forward the base. We can only do that when
 	 * @basej is past base->clk otherwise we might rewind base->clk.
 	 */
-	if (time_before_eq(jnow, base->clk))
+	if (time_before_eq(basej, base->clk))
 		return;
 
 	/*
 	 * If the next expiry value is > jiffies, then we fast forward to
 	 * jiffies otherwise we forward to the next expiry value.
 	 */
-	if (time_after(base->next_expiry, jnow)) {
-		base->clk = jnow;
+	if (time_after(base->next_expiry, basej)) {
+		base->clk = basej;
 	} else {
 		if (WARN_ON_ONCE(time_before(base->next_expiry, base->clk)))
 			return;
 		base->clk = base->next_expiry;
 	}
+
 }
 
+static inline void forward_timer_base(struct timer_base *base)
+{
+	__forward_timer_base(base, READ_ONCE(jiffies));
+}
 
 /*
  * We are using hashed locking: Holding per_cpu(timer_bases[x]).lock means

  reply	other threads:[~2023-12-20 15:59 UTC|newest]

Thread overview: 86+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01  9:26 [PATCH v9 00/32] timers: Move from a push remote at enqueue to a pull at expiry model Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 01/32] tick-sched: Fix function names in comments Anna-Maria Behnsen
2023-12-20 13:09   ` Frederic Weisbecker
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 02/32] tick/sched: Cleanup confusing variables Anna-Maria Behnsen
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 03/32] tick-sched: Warn when next tick seems to be in the past Anna-Maria Behnsen
2023-12-20 13:27   ` Frederic Weisbecker
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 04/32] tracing/timers: Enhance timer_start tracepoint Anna-Maria Behnsen
2023-12-20 13:35   ` Frederic Weisbecker
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 05/32] tracing/timers: Add tracepoint for tracking timer base is_idle flag Anna-Maria Behnsen
2023-12-20 13:43   ` Frederic Weisbecker
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 06/32] timers: Do not IPI for deferrable timers Anna-Maria Behnsen
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 07/32] timers: Move store of next event into __next_timer_interrupt() Anna-Maria Behnsen
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 08/32] timers: Clarify check in forward_timer_base() Anna-Maria Behnsen
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 09/32] timers: Split out forward timer base functionality Anna-Maria Behnsen
2023-12-20 15:59   ` tip-bot2 for Anna-Maria Behnsen [this message]
2023-12-01  9:26 ` [PATCH v9 10/32] timers: Use already existing function for forwarding timer base Anna-Maria Behnsen
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 11/32] timers: Rework idle logic Anna-Maria Behnsen
2023-12-20 14:00   ` Frederic Weisbecker
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Thomas Gleixner
2023-12-01  9:26 ` [PATCH v9 12/32] timers: Fix nextevt calculation when no timers are pending Anna-Maria Behnsen
2023-12-04 16:03   ` Sebastian Siewior
2023-12-05 11:53     ` Anna-Maria Behnsen
2023-12-10  0:35       ` Frederic Weisbecker
2023-12-12 13:21         ` Anna-Maria Behnsen
2023-12-12 13:37           ` Frederic Weisbecker
2023-12-20 14:49   ` Frederic Weisbecker
2023-12-20 15:59   ` [tip: timers/core] " tip-bot2 for Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 13/32] timers: Restructure get_next_timer_interrupt() Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 14/32] timers: Split out get next timer interrupt Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 15/32] timers: Move marking timer bases idle into tick_nohz_stop_tick() Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 16/32] timers: Optimization for timer_base_try_to_set_idle() Anna-Maria Behnsen
2023-12-04 17:52   ` Sebastian Siewior
2023-12-05 12:05     ` Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 17/32] timers: Introduce add_timer() variants which modify timer flags Anna-Maria Behnsen
2023-12-05 18:28   ` Sebastian Siewior
2023-12-06  9:24     ` Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 18/32] workqueue: Use global variant for add_timer() Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 19/32] timers: add_timer_on(): Make sure TIMER_PINNED flag is set Anna-Maria Behnsen
2023-12-05 18:29   ` Sebastian Siewior
2023-12-06  9:57     ` Anna-Maria Behnsen
2023-12-06 10:26       ` Sebastian Siewior
2023-12-06 10:46         ` Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 20/32] timers: Ease code in run_local_timers() Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 21/32] timers: Split next timer interrupt logic Anna-Maria Behnsen
2023-12-05 18:29   ` Sebastian Siewior
2023-12-01  9:26 ` [PATCH v9 22/32] timers: Keep the pinned timers separate from the others Anna-Maria Behnsen
2023-12-05 21:11   ` Sebastian Siewior
2023-12-06 10:23     ` Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 23/32] timers: Retrieve next expiry of pinned/non-pinned timers separately Anna-Maria Behnsen
2023-12-06  9:47   ` Sebastian Siewior
2023-12-07 10:12     ` Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 24/32] timers: Split out "get next timer interrupt" functionality Anna-Maria Behnsen
2023-12-06 10:20   ` Sebastian Siewior
2023-12-01  9:26 ` [PATCH v9 25/32] timers: Add get next timer interrupt functionality for remote CPUs Anna-Maria Behnsen
2023-12-06 10:44   ` Sebastian Siewior
2023-12-07 10:27     ` Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 26/32] timers: Restructure internal locking Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 27/32] timers: Check if timers base is handled already Anna-Maria Behnsen
2023-12-06 10:58   ` Sebastian Siewior
2023-12-01  9:26 ` [PATCH v9 28/32] tick/sched: Split out jiffies update helper function Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 29/32] timers: Introduce function to check timer base is_idle flag Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 30/32] timers: Implement the hierarchical pull model Anna-Maria Behnsen
2023-12-06 16:35   ` Sebastian Siewior
2023-12-08  9:01     ` Anna-Maria Behnsen
2023-12-07 18:09   ` Sebastian Siewior
2023-12-08 10:31     ` Anna-Maria Behnsen
2023-12-08 18:18   ` Sebastian Siewior
2023-12-11 18:04   ` Sebastian Siewior
2023-12-12 11:31     ` Anna-Maria Behnsen
2023-12-12 11:43       ` Anna-Maria Behnsen
2023-12-12 15:59       ` Sebastian Siewior
2023-12-12 12:14   ` Sebastian Siewior
2023-12-12 14:52     ` Anna-Maria Behnsen
2023-12-12 17:08       ` Sebastian Siewior
2023-12-01  9:26 ` [PATCH v9 31/32] timer_migration: Add tracepoints Anna-Maria Behnsen
2023-12-01  9:26 ` [PATCH v9 32/32] timers: Always queue timers on the local CPU Anna-Maria Behnsen
2023-12-07 12:11 ` [PATCH v9 00/32] timers: Move from a push remote at enqueue to a pull at expiry model Anna-Maria Behnsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170308794724.398.14686394808339432944.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=anna-maria@linutronix.de \
    --cc=frederic@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®