From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 55E781F926; Wed, 3 Jan 2024 23:58:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BvTQ1CIZ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8D093C433C7; Wed, 3 Jan 2024 23:58:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704326309; bh=iA9WYfGY5Z4oYdMSbRGnFplo2MhKh0V9KxXo9sQm5Pk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BvTQ1CIZJ3c3bkAHjb38KAjylqYtdc8OhUUlTB7ZU0IsHEYDYPWrErA1dcymNAIME 7v06xr59dNgxWQNp6/RGwGHtEGPOD2ExIrSJgRRVYmf3SKoKvUYOS/IRkTj8gmcFrG sDIJqQrJ1oJj39puhnIzsvZ3Hxas6Fz4kQWNLsdmuTjTynu4Ij3reRGCDq3hcAjLOe iSSAu7ut2lfbPaP02Ug5BB1sgqo0NyoOOWNMwx6NInkjO85zhLB/A4kWp68+18en8u I6/exVME/cc79Suz+bOFCnTVUYPhmidOkUzDuH4kT4T9IdolOY/U+5iLxtFRSS3lfA CmquNDbEAvzkQ== Received: (nullmailer pid 2042297 invoked by uid 1000); Wed, 03 Jan 2024 23:58:27 -0000 Date: Wed, 3 Jan 2024 16:58:27 -0700 From: Rob Herring To: =?iso-8859-1?Q?Andr=E9?= Draszik Cc: Rob Herring , Masahiro Yamada , Conor Dooley , Mathieu Poirier , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Krzysztof Kozlowski Subject: Re: [PATCH] dt-bindings: ignore paths outside kernel for DT_SCHEMA_FILES Message-ID: <170432630603.2042234.10993333941885772911.robh@kernel.org> References: <20231220145537.2163811-1-andre.draszik@linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231220145537.2163811-1-andre.draszik@linaro.org> On Wed, 20 Dec 2023 14:55:37 +0000, André Draszik wrote: > If the location of the kernel sources contains the string that we're > filtering for using DT_SCHEMA_FILES, then all schemas will currently be > matched, returned and checked, not just the ones we actually expected. > As an example, if the kernel sources happen to be below a directory > 'google', and DT_SCHEMA_FILES=google, everything is checked. More > common examples might be having the sources below people's home > directories that contain the string st or arm and then searching for > those. The list is endless. > > Fix this by only matching for schemas below the kernel source's > bindings directory. > > Note that I opted for the implementation here so as to not having to > deal with escaping DT_SCHEMA_FILES, which would have been the > alternative if the grep match itself had been updated. > > Cc: Masahiro Yamada > Signed-off-by: André Draszik > --- > Documentation/devicetree/bindings/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied, thanks!