mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Petlozu Pravareshwar <petlozup@nvidia.com>
Cc: conor+dt@kernel.org, cai.huoqing@linux.dev,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	ulf.hansson@linaro.org, thierry.reding@gmail.com,
	krzysztof.kozlowski+dt@linaro.org, p.zabel@pengutronix.de,
	spatra@nvidia.com, linux-tegra@vger.kernel.org,
	kkartik@nvidia.com, robh+dt@kernel.org,
	dmitry.osipenko@collabora.com, jonathanh@nvidia.com
Subject: Re: [PATCH 2/3] dt-bindings: tegra: pmc: Update scratch as an optional aperture
Date: Sat, 06 Jan 2024 02:51:50 -0700	[thread overview]
Message-ID: <170453471019.703179.18182038720980471680.robh@kernel.org> (raw)
In-Reply-To: <20240106075134.3933491-2-petlozup@nvidia.com>


On Sat, 06 Jan 2024 07:51:33 +0000, Petlozu Pravareshwar wrote:
> Scratch address space register is used to store reboot reason. For
> some Tegra234 systems, the scratch space is not available to store
> the reboot reason. This is because scratch region on these systems
> is not accessible by the kernel as restricted by the Hypervisor.
> Such systems would delist scratch aperture from PMC DT node.
> 
> Accordingly, this change makes "scratch" as an optional aperture for
> Tegra234 in PMC dt-binding document.
> 
> Signed-off-by: Petlozu Pravareshwar <petlozup@nvidia.com>
> ---
>  .../arm/tegra/nvidia,tegra186-pmc.yaml        | 83 +++++++++++++------
>  1 file changed, 58 insertions(+), 25 deletions(-)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/arm/tegra/nvidia,tegra186-pmc.yaml:85:12: [warning] wrong indentation: expected 12 but found 11 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240106075134.3933491-2-petlozup@nvidia.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-01-06  9:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-06  7:51 [PATCH 1/3] soc/tegra: pmc: Update address mapping sequence for PMC apertures Petlozu Pravareshwar
2024-01-06  7:51 ` [PATCH 2/3] dt-bindings: tegra: pmc: Update scratch as an optional aperture Petlozu Pravareshwar
2024-01-06  9:51   ` Rob Herring [this message]
2024-01-17 15:41     ` Petlozu Pravareshwar
2024-01-08 16:16   ` kernel test robot
2024-01-08 19:58   ` Rob Herring
2024-01-17 15:46     ` Petlozu Pravareshwar
2024-01-06  7:51 ` [PATCH 3/3] soc/tegra: " Petlozu Pravareshwar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170453471019.703179.18182038720980471680.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=cai.huoqing@linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.osipenko@collabora.com \
    --cc=jonathanh@nvidia.com \
    --cc=kkartik@nvidia.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=petlozup@nvidia.com \
    --cc=robh+dt@kernel.org \
    --cc=spatra@nvidia.com \
    --cc=thierry.reding@gmail.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®