From: Rob Herring <robh@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: Paolo Abeni <pabeni@redhat.com>,
Emil Renner Berthing <kernel@esmil.dk>,
devicetree@vger.kernel.org,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
netdev@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
linux-stm32@st-md-mailman.stormreply.com,
Jose Abreu <joabreu@synopsys.com>,
Conor Dooley <conor+dt@kernel.org>,
Jakub Kicinski <kuba@kernel.org>,
Samin Guo <samin.guo@starfivetech.com>,
linux-arm-kernel@lists.infradead.org,
Jacob Keller <jacob.e.keller@intel.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
kernel@collabora.com
Subject: Re: [PATCH v3 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible
Date: Mon, 8 Jan 2024 20:08:40 -0700 [thread overview]
Message-ID: <170476971804.2467890.1994452217560064962.robh@kernel.org> (raw)
In-Reply-To: <20231222101001.2541758-2-cristian.ciocaltea@collabora.com>
On Fri, 22 Dec 2023 12:09:59 +0200, Cristian Ciocaltea wrote:
> The Synopsys DesignWare MAC found on StarFive JH7100 SoC is mostly
> similar to the newer JH7110, but it requires only two interrupts and a
> single reset line, which is 'ahb' instead of the commonly used
> 'stmmaceth'.
>
> Since the common binding 'snps,dwmac' allows selecting 'ahb' only in
> conjunction with 'stmmaceth', extend the logic to also permit exclusive
> usage of the 'ahb' reset name. This ensures the following use cases are
> supported:
>
> JH7110: reset-names = "stmmaceth", "ahb";
> JH7100: reset-names = "ahb";
> other: reset-names = "stmmaceth";
>
> Also note the need to use a different dwmac fallback, as v5.20 applies
> to JH7110 only, while JH7100 relies on v3.7x.
>
> Additionally, drop the reset description items from top-level binding as
> they are already provided by the included snps,dwmac schema.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 11 +--
> .../bindings/net/starfive,jh7110-dwmac.yaml | 72 +++++++++++++------
> 2 files changed, 57 insertions(+), 26 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2024-01-09 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-22 10:09 [PATCH v3 0/2] StarFive DWMAC support for JH7100 Cristian Ciocaltea
2023-12-22 10:09 ` [PATCH v3 1/2] dt-bindings: net: starfive,jh7110-dwmac: Add JH7100 SoC compatible Cristian Ciocaltea
2024-01-09 3:08 ` Rob Herring [this message]
2023-12-22 10:10 ` [PATCH v3 2/2] net: stmmac: dwmac-starfive: Add support for JH7100 SoC Cristian Ciocaltea
2024-01-02 23:02 ` [PATCH v3 0/2] StarFive DWMAC support for JH7100 Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170476971804.2467890.1994452217560064962.robh@kernel.org \
--to=robh@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jacob.e.keller@intel.com \
--cc=joabreu@synopsys.com \
--cc=kernel@collabora.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh+dt@kernel.org \
--cc=samin.guo@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®