mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>
Cc: davem@davemloft.net, kuba@kernel.org, devicetree@vger.kernel.org,
	 robh+dt@kernel.org, hkallweit1@gmail.com, linux@armlinux.org.uk,
	 krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch,
	edumazet@google.com,  pabeni@redhat.com,
	linux-kernel@vger.kernel.org, afd@ti.com,
	 netdev@vger.kernel.org, conor+dt@kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: net: dp83826: add ti,cfg-dac-minus binding
Date: Thu, 11 Jan 2024 15:01:35 -0600	[thread overview]
Message-ID: <170500673265.1110563.4649305262591407339.robh@kernel.org> (raw)
In-Reply-To: <20240111161927.3689084-1-catalin.popescu@leica-geosystems.com>


On Thu, 11 Jan 2024 17:19:25 +0100, Catalin Popescu wrote:
> Add property ti,cfg-dac-minus to allow for voltage tuning
> of logical level -1 of the MLT-3 encoded data.
> 
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>
> ---
>  Documentation/devicetree/bindings/net/ti,dp83822.yaml | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/ti,dp83822.yaml: ti,cfg-dac-minus: missing type definition

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240111161927.3689084-1-catalin.popescu@leica-geosystems.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  parent reply	other threads:[~2024-01-11 21:01 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-11 16:19 Catalin Popescu
2024-01-11 16:19 ` [PATCH 2/3] dt-bindings: net: dp83826: add ti,cfg-dac-plus binding Catalin Popescu
2024-01-11 16:45   ` POPESCU Catalin
2024-01-11 17:21   ` Krzysztof Kozlowski
2024-01-12 10:56     ` POPESCU Catalin
2024-01-11 21:01   ` Rob Herring
2024-01-13 19:16   ` kernel test robot
2024-01-11 16:19 ` [PATCH 3/3] net: phy: dp83826: add support for voltage tuning of logical levels Catalin Popescu
2024-01-11 16:45   ` Andrew Lunn
2024-01-11 16:54     ` POPESCU Catalin
2024-01-13  3:26   ` kernel test robot
2024-01-11 16:35 ` [PATCH 1/3] dt-bindings: net: dp83826: add ti,cfg-dac-minus binding Andrew Lunn
2024-01-11 16:45   ` POPESCU Catalin
2024-01-11 16:47     ` Andrew Lunn
2024-01-12 10:56       ` POPESCU Catalin
2024-01-11 16:52     ` Russell King (Oracle)
2024-01-11 16:59       ` POPESCU Catalin
2024-01-11 17:21         ` Krzysztof Kozlowski
2024-01-12 13:41           ` POPESCU Catalin
2024-01-12 13:47             ` Krzysztof Kozlowski
2024-01-11 17:20 ` Krzysztof Kozlowski
2024-01-12 11:02   ` POPESCU Catalin
2024-01-11 21:01 ` Rob Herring [this message]
2024-01-13  6:10 ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170500673265.1110563.4649305262591407339.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=afd@ti.com \
    --cc=andrew@lunn.ch \
    --cc=catalin.popescu@leica-geosystems.com \
    --cc=conor+dt@kernel.org \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=hkallweit1@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®