mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
Cc: Thomas Zimmermann <tzimmermann@suse.de>,
	 Alexandre Torgue <alexandre.torgue@foss.st.com>,
	 Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	 Philippe Cornu <philippe.cornu@foss.st.com>,
	 Rob Herring <robh+dt@kernel.org>,
	 Maxime Coquelin <mcoquelin.stm32@gmail.com>,
	devicetree@vger.kernel.org,  dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org,
	 Conor Dooley <conor+dt@kernel.org>,
	linux-kernel@vger.kernel.org,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>,
	 linux-stm32@st-md-mailman.stormreply.com,
	 Philipp Zabel <p.zabel@pengutronix.de>,
	 Yannick Fertre <yannick.fertre@foss.st.com>,
	 Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device
Date: Mon, 15 Jan 2024 08:32:54 -0600	[thread overview]
Message-ID: <170532917312.565061.10381473169126019945.robh@kernel.org> (raw)
In-Reply-To: <20240115132009.101718-2-raphael.gallais-pou@foss.st.com>


On Mon, 15 Jan 2024 14:20:04 +0100, Raphael Gallais-Pou wrote:
> Add "st,stm32mp25-lvds" compatible.
> 
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@foss.st.com>
> ---
> Depends on: "dt-bindings: stm32: add clocks and reset binding for
> 	    stm32mp25 platform" by Gabriel Fernandez
> 
> Changes in v3:
> 	- Clarify commit dependency
> 	- Fix includes in the example
> 	- Fix YAML
> 	- Add "clock-cells" description
> 	- s/regroups/is composed of/
> 	- Changed compatible to show SoC specificity
> 
> Changes in v2:
> 	- Switch compatible and clock-cells related areas
> 	- Remove faulty #include in the example.
> 	- Add entry in MAINTAINERS
> ---
>  .../bindings/display/st,stm32-lvds.yaml       | 119 ++++++++++++++++++
>  MAINTAINERS                                   |   1 +
>  2 files changed, 120 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/display/st,stm32-lvds.example.dts:18:18: fatal error: dt-bindings/clock/st,stm32mp25-rcc.h: No such file or directory
   18 |         #include <dt-bindings/clock/st,stm32mp25-rcc.h>
      |                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/display/st,stm32-lvds.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1424: dt_binding_check] Error 2
make: *** [Makefile:234: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240115132009.101718-2-raphael.gallais-pou@foss.st.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-01-15 14:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 13:20 [PATCH v3 0/6] Introduce STM32 LVDS driver Raphael Gallais-Pou
2024-01-15 13:20 ` [PATCH v3 1/6] dt-bindings: display: add dt-bindings for STM32 LVDS device Raphael Gallais-Pou
2024-01-15 14:32   ` Rob Herring [this message]
2024-01-15 15:46   ` Rob Herring
2024-01-15 16:51     ` Raphael Gallais-Pou
2024-01-16  7:42       ` Krzysztof Kozlowski
2024-01-18 15:06         ` Raphael Gallais-Pou
2024-01-15 13:20 ` [PATCH v3 2/6] drm/stm: lvds: add new STM32 LVDS Display Interface Transmitter driver Raphael Gallais-Pou
2024-01-15 13:20 ` [PATCH v3 3/6] drm/stm: ltdc: add lvds pixel clock Raphael Gallais-Pou
2024-01-15 13:20 ` [PATCH v3 4/6] arm64: dts: st: add ltdc support on stm32mp251 Raphael Gallais-Pou
2024-01-15 13:20 ` [PATCH v3 5/6] arm64: dts: st: add lvds support on stm32mp255 Raphael Gallais-Pou
2024-01-15 13:20 ` [PATCH v3 6/6] arm64: dts: st: add display support on stm32mp257f-ev Raphael Gallais-Pou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170532917312.565061.10381473169126019945.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=airlied@gmail.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=conor+dt@kernel.org \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mripard@kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=philippe.cornu@foss.st.com \
    --cc=raphael.gallais-pou@foss.st.com \
    --cc=robh+dt@kernel.org \
    --cc=tzimmermann@suse.de \
    --cc=yannick.fertre@foss.st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®