From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754057AbbBKUb0 (ORCPT ); Wed, 11 Feb 2015 15:31:26 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57027 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752614AbbBKUbX (ORCPT ); Wed, 11 Feb 2015 15:31:23 -0500 Date: Wed, 11 Feb 2015 21:31:17 +0100 (CET) From: Stefan Wahren Reply-To: Stefan Wahren To: Fabio Estevam Cc: Sascha Hauer , linux-kernel , Shawn Guo , Mike Turquette , "linux-arm-kernel@lists.infradead.org" , Marek Vasut , Zhi Li Message-ID: <1705379122.406018.1423686677196.JavaMail.open-xchange@oxbaltgw01.schlund.de> In-Reply-To: References: <1422645610-3052-1-git-send-email-stefan.wahren@i2se.com> <54DA020C.6030703@i2se.com> <54DA0DE7.5050708@i2se.com> <462270270.419156.1423603473431.JavaMail.open-xchange@oxbaltgw02.schlund.de> Subject: Re: [PATCH V2 RESEND] clk: mxs: Fix invalid 32-bit access to frac registers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.6.0-Rev36 X-Originating-Client: com.openexchange.ox.gui.dhtml X-Provags-ID: V03:K0:2OWkESpQMPtV5zi43hIg/hS8YbQtzRB453aifSjrjaeIstPZ3Ve MBtFU06pKRbS6JAgSgSG6IrJslv/mqnqGdewnhOaUHqFpBoPePUol15pfdq8vyv1W1Uu9Oa FAFTbVq48rJmWhi3h1iE9Mtq1YYx3q+jSMwz6+QNaMhn1btTl5owkLKV5oZn/j8XaIOK98a Z5wJD/ryVGRi87OdQ9Jmw== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Fabio, > Fabio Estevam hat am 11. Februar 2015 um 17:58 > geschrieben: > > > Hi Stefan, > > On Tue, Feb 10, 2015 at 7:24 PM, Stefan Wahren wrote: > > Hi Fabio, > > > >> Fabio Estevam hat am 10. Februar 2015 um 16:06 > >> geschrieben: > >> > >> > >> Hi Stefan, > >> > >> On Tue, Feb 10, 2015 at 11:55 AM, Stefan Wahren > >> wrote: > >> > >> > Could you apply only the clk-imx28.c part of my patch and see what > >> > happens? > >> > >> If I apply only the clk-imx28.c part of your patch I can successfully > >> probe the SPI NOR. > > > > thanks this is very helpful. I built the linux-next for my Duckbill and add > > the > > SSP2 section from imx28-evk.dts into imx28-duckbill.dts. > > > > Without my patch i get the following for HW_CLKCTRL_FRAC0: > > > > ./memwatch -a 0x800401B0 > > > > 0x800401b0: 0x5e5b5513 > > > > With my patch i get: > > > > ./memwatch -a 0x800401B0 > > > > 0x800401b0: 0x5e1b5513 > > I always get 0x5e5b5513 with or without your patch. very strange. Do you have any idea why IO1_STABLE is permanent low? Here are the register dumps as requested by Mike. Without this patch after boot 0x80040000: 0x00060000 0x80040010: 0x800004b1 0x80040050: 0x00011001 0x80040080: 0x64000001 0x80040090: 0x00000001 0x800400a0: 0x80000001 0x800400b0: 0x00000002 0x800400c0: 0xa0000001 0x800401b0: 0x5e5b5513 0x800401c0: 0x00929292 0x800401d0: 0x00004104 With this patch after boot 0x80040000: 0x00060000 0x80040010: 0x800004b1 0x80040050: 0x00011001 0x80040080: 0x64000001 0x80040090: 0x00000001 0x800400a0: 0x80000001 0x800400b0: 0x00000002 0x800400c0: 0xa0000001 0x800401b0: 0x5e1b5513 0x800401c0: 0x00929292 0x800401d0: 0x00004104 So only IO1_STABLE (0x800401b0) is different. If i restore clk_ref_set_rate() from clk-ref.c after the complete patch is applied, the issue with the IO1_STABLE bit disappears. Can you confirm the behavior according to your flash issue? I think it would be the best to revert my patch. Sorry for the trouble. Stefan > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel