mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: imx@lists.linux.dev, krzysztof.kozlowski+dt@linaro.org,
	 mark.rutland@arm.com, devicetree@vger.kernel.org,
	linux-usb@vger.kernel.org,  robh+dt@kernel.org,
	conor+dt@kernel.org, balbi@kernel.org,  mathias.nyman@intel.com,
	sergei.shtylyov@cogentembedded.com,  thinh.nguyen@synopsys.com,
	gregkh@linuxfoundation.org, pku.leo@gmail.com,
	 linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: usb: dwc3: Add system bus request info
Date: Tue, 23 Jan 2024 12:37:34 -0600	[thread overview]
Message-ID: <170603505074.1430842.17793534991296017470.robh@kernel.org> (raw)
In-Reply-To: <20240123170206.3702413-1-Frank.Li@nxp.com>


On Tue, 23 Jan 2024 12:02:05 -0500, Frank Li wrote:
> Add device tree binding allow platform overwrite default value of *REQIN in
> GSBUSCFG0.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  .../devicetree/bindings/usb/snps,dwc3.yaml    | 36 +++++++++++++++++++
>  1 file changed, 36 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:
./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:447:43: [error] syntax error: mapping values are not allowed here (syntax)

dtschema/dtc warnings/errors:
make[2]: *** Deleting file 'Documentation/devicetree/bindings/usb/snps,dwc3.example.dts'
Documentation/devicetree/bindings/usb/snps,dwc3.yaml:447:43: mapping values are not allowed in this context
make[2]: *** [Documentation/devicetree/bindings/Makefile:26: Documentation/devicetree/bindings/usb/snps,dwc3.example.dts] Error 1
make[2]: *** Waiting for unfinished jobs....
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,keystone-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/samsung,exynos-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/fsl,imx8mp-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/dwc3-xilinx.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/rockchip,rk3399-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/amlogic,meson-g12a-usb-ctrl.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,am62-usb.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/realtek,rtd-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/fsl,imx8mq-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/intel,keembay-dwc3.yaml:
mapping values are not allowed in this context
  in "<unicode string>", line 447, column 43
./Documentation/devicetree/bindings/usb/snps,dwc3.yaml:447:43: mapping values are not allowed in this context
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/snps,dwc3.yaml: ignoring, error parsing file
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240123170206.3702413-1-Frank.Li@nxp.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


      parent reply	other threads:[~2024-01-23 18:37 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-23 17:02 Frank Li
2024-01-23 17:02 ` [PATCH 2/2] usb: dwc3: core: allow overwrite reqinfo in GSBUSCFG0 by dts Frank Li
2024-01-23 17:27 ` [PATCH 1/2] dt-bindings: usb: dwc3: Add system bus request info Conor Dooley
2024-01-23 17:49   ` Frank Li
2024-01-23 17:51     ` Conor Dooley
2024-01-23 18:02       ` Frank Li
2024-01-23 18:42         ` Conor Dooley
2024-01-23 19:22           ` Frank Li
2024-01-23 21:46             ` Krzysztof Kozlowski
2024-01-23 22:23               ` Frank Li
2024-01-29 15:19                 ` Frank Li
2024-01-29 16:49                   ` Conor Dooley
2024-01-29 17:41                     ` Frank Li
2024-01-30  7:40                       ` Krzysztof Kozlowski
2024-01-30 15:20                         ` Frank Li
2024-01-30 16:10                           ` Krzysztof Kozlowski
2024-02-08 21:20                             ` Frank Li
2024-02-09  7:31                               ` Krzysztof Kozlowski
2024-01-23 18:37 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170603505074.1430842.17793534991296017470.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=Frank.Li@nxp.com \
    --cc=balbi@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=imx@lists.linux.dev \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mathias.nyman@intel.com \
    --cc=pku.leo@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=thinh.nguyen@synopsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®