From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81914200D4; Sat, 27 Jan 2024 18:16:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706379411; cv=none; b=VbhGFXWSnlt8kKLiLuV9/Ve5JjVEN8Jty8qaeCuHiXBGv3moKYKRls2TIrhVPvr53VI+zTZcyPn8rSHzoTFDy6CNPI3e/KFpbz8XfyZB1W1hCojCOmuohyJtYbrYPTUzVvMDGdqdMQ+G5y/DlLT+nEKPujSZXte2fOPHQ12QlMQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706379411; c=relaxed/simple; bh=+1qi4MjbtS4pEJymhwXKOEn8nfKHKnTrO6/g0+h1qy8=; h=From:To:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kQFJbUSWvDMQQeFvlOWSFwG8MYD1rv/dAGiSDnBjMS+LldUAP2wfAFZU9g665cC9faw5wK8dT4ArSn9BSuv9TTCVEqyR20R0c11jU1VYePtIS98Qvxtr3PZMVyc4u7zbcL4VFvRZNHYnl9URaDvqRmsnM7M2PnrfmsnR83lKNzA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=G+qECXtT; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="G+qECXtT" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 798F6C433C7; Sat, 27 Jan 2024 18:16:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706379411; bh=+1qi4MjbtS4pEJymhwXKOEn8nfKHKnTrO6/g0+h1qy8=; h=From:To:Subject:Date:In-Reply-To:References:From; b=G+qECXtTL97hIGQi+49kC6uCKcMn9ZR9Y9PZG+NNcr2FueGnAVatJ1xRkVuIKoOnt 5cfSXUAtiVNXboAjeqW8HA5B+ro/3ouXabxEfQJSm/J5ZRZfgwv2wh6JzPySuPwZlj exLoFTQizCOxOd3LYK3qdfEonsOPTikvySGBtX7EKzpnl+Xu/hGHJZo+GLDU7G8uAk XH/OwPOuKq2I0GBlRrIUieTm3NgeTUDiOZJ+7z+iaCM0N7o5vEkTeJhiIbmyDBobhI cmhs+ERtdFjX9S8fLUo6J5j8iRxPA+ZUxqev+h0qQeQbgjiwfLfr53QW+DpI51VudL bzAFahrdgff8g== From: Namhyung Kim To: Kan Liang , Mark Rutland , Weilin Wang , Adrian Hunter , linux-perf-users@vger.kernel.org, Ian Rogers , James Clark , Peter Zijlstra , Samantha Alt , Ingo Molnar , Alexander Shishkin , Caleb Biggers , Jiri Olsa , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, Edward Baker , Perry Taylor Subject: Re: [PATCH v1] perf pmu: Treat the msr pmu as software Date: Sat, 27 Jan 2024 10:16:47 -0800 Message-ID: <170637928210.816351.6189596994646336873.b4-ty@kernel.org> X-Mailer: git-send-email 2.43.0.429.g432eaa2c6b-goog In-Reply-To: <20240124234200.1510417-1-irogers@google.com> References: <20240124234200.1510417-1-irogers@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Wed, 24 Jan 2024 15:42:00 -0800, Ian Rogers wrote: > The msr PMU is a software one, meaning msr events may be grouped > with events in a hardware context. As the msr PMU isn't marked as a > software PMU by perf_pmu__is_software, groups with the msr PMU in > are broken and the msr events placed in a different group. This > may lead to multiplexing errors where a hardware event isn't > counted while the msr event, such as tsc, is. Fix all of this by > marking the msr PMU as software, which agrees with the driver. > > [...] Applied to perf-tools-next, thanks! Best regards, -- Namhyung Kim