From: Bjorn Andersson <andersson@kernel.org>
To: konrad.dybcio@linaro.org, Tao Zhang <quic_taozhan@quicinc.com>
Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel@quicinc.com
Subject: Re: [PATCH] qcom: smem: remove hwspinlock from item get routine
Date: Sun, 28 Jan 2024 11:45:52 -0600 [thread overview]
Message-ID: <170646395043.64610.5018917783604688842.b4-ty@kernel.org> (raw)
In-Reply-To: <20240102022512.999635-1-quic_taozhan@quicinc.com>
On Tue, 02 Jan 2024 07:55:12 +0530, Tao Zhang wrote:
> During an SSR(Sub-System Restart) process, the remoteproc driver will
> try to read the crash reason from SMEM. The qcom_smem_get() backing such
> operations does however take the hwspinlock (tcsr mutex), which might be
> held by the dying remoteproc.
>
> The associated timeout on the hwspin_lock_timeout_irqsave() would take
> care of the system not hanging forever, but the get operation will fail,
> unnecessarily delaying the process for the 'HWSPINLOCK_TIMEOUT' duration
> (currently is '1s'), and finally resulting in failure to get crash
> information from SMEM.
>
> [...]
Applied, thanks!
[1/1] qcom: smem: remove hwspinlock from item get routine
commit: 27825593c972abac86b9a4453a8c8c9a2c1ec60f
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2024-01-28 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-02 2:25 Tao Zhang
2024-01-27 0:23 ` Chris Lew
2024-01-28 17:45 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170646395043.64610.5018917783604688842.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_taozhan@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®