From: Mihai Carabas <mihai.carabas@oracle.com>
To: linux-arm-kernel@lists.infradead.org
Cc: kvm@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, catalin.marinas@arm.com,
will@kernel.org, tglx@linutronix.de, mingo@redhat.com,
bp@alien8.de, x86@kernel.org, hpa@zytor.com, pbonzini@redhat.com,
wanpengli@tencent.com, vkuznets@redhat.com, rafael@kernel.org,
daniel.lezcano@linaro.org, akpm@linux-foundation.org,
pmladek@suse.com, peterz@infradead.org, dianders@chromium.org,
npiggin@gmail.com, rick.p.edgecombe@intel.com,
joao.m.martins@oracle.com, juerg.haefliger@canonical.com,
mic@digikod.net, mihai.carabas@oracle.com, arnd@arndb.de,
ankur.a.arora@oracle.com
Subject: [PATCH v3 3/7] governors/haltpoll: Drop kvm_para_available() check
Date: Mon, 29 Jan 2024 12:40:30 +0200 [thread overview]
Message-ID: <1706524834-11275-4-git-send-email-mihai.carabas@oracle.com> (raw)
In-Reply-To: <1706524834-11275-1-git-send-email-mihai.carabas@oracle.com>
From: Joao Martins <joao.m.martins@oracle.com>
This is duplicated already in the haltpoll idle driver,
and there's no need to re-check KVM guest availability in
the governor.
Either guests uses the module which explicitly selects this
governor, and given that it has the lowest rating of all governors
(menu=20,teo=19,ladder=10/25,haltpoll=9) means that unless it's
the only one compiled in, it won't be selected.
Dropping such check also allows to test haltpoll in baremetal.
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: Mihai Carabas <mihai.carabas@oracle.com>
Acked-by: Rafael J. Wysocki <rafael@kernel.org>
---
drivers/cpuidle/governors/haltpoll.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/cpuidle/governors/haltpoll.c b/drivers/cpuidle/governors/haltpoll.c
index 1dff3a52917d..c9b69651d377 100644
--- a/drivers/cpuidle/governors/haltpoll.c
+++ b/drivers/cpuidle/governors/haltpoll.c
@@ -143,10 +143,7 @@ static int haltpoll_enable_device(struct cpuidle_driver *drv,
static int __init init_haltpoll(void)
{
- if (kvm_para_available())
- return cpuidle_register_governor(&haltpoll_governor);
-
- return 0;
+ return cpuidle_register_governor(&haltpoll_governor);
}
postcore_initcall(init_haltpoll);
--
1.8.3.1
next prev parent reply other threads:[~2024-01-29 11:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-29 10:40 [PATCH v3] Enable haltpoll for arm64 Mihai Carabas
2024-01-29 10:40 ` [PATCH v3 1/7] x86: Move ARCH_HAS_CPU_RELAX to arch Mihai Carabas
2024-01-29 10:40 ` [PATCH v3 2/7] x86/kvm: Move haltpoll_want() to be arch defined Mihai Carabas
2024-01-29 10:40 ` Mihai Carabas [this message]
2024-01-29 10:40 ` [PATCH v3 4/7] arm64: Select ARCH_HAS_CPU_RELAX Mihai Carabas
2024-01-29 10:40 ` [PATCH v3 5/7] arm64: Define TIF_POLLING_NRFLAG Mihai Carabas
2024-01-29 10:40 ` [PATCH v3 6/7] cpuidle-haltpoll: ARM64 support Mihai Carabas
2024-01-29 10:40 ` [PATCH v3 7/7] cpuidle/poll_state: replace cpu_relax with smp_cond_load_relaxed Mihai Carabas
2024-01-29 14:52 ` Rafael J. Wysocki
2024-01-29 19:20 ` Mihai Carabas
2024-01-29 19:41 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1706524834-11275-4-git-send-email-mihai.carabas@oracle.com \
--to=mihai.carabas@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=ankur.a.arora@oracle.com \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dianders@chromium.org \
--cc=hpa@zytor.com \
--cc=joao.m.martins@oracle.com \
--cc=juerg.haefliger@canonical.com \
--cc=kvm@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mic@digikod.net \
--cc=mingo@redhat.com \
--cc=npiggin@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rafael@kernel.org \
--cc=rick.p.edgecombe@intel.com \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®