mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Umang Jain <umang.jain@ideasonboard.com>, linux-media@vger.kernel.org
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Umang Jain <umang.jain@ideasonboard.com>,
	Matthias Fend <matthias.fend@emfend.at>,
Subject: Re: [PATCH v2 1/5] media: i2c: imx335: Drop setting of 0x3a00 register
Date: Wed, 31 Jan 2024 09:52:54 +0000	[thread overview]
Message-ID: <170669477439.1011926.18210850208916698098@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <20240131055208.170934-2-umang.jain@ideasonboard.com>

Hi Umang,

+ Cc: Matthias

Quoting Umang Jain (2024-01-31 05:52:04)
> Register 0x3a00 is a reserved field as per the IMX335 datasheet,
> hence shouldn't be set by the driver.

We still need to explain more about why we're dropping this register
write, and what effects it causes.

Matthias - I believe this stemmed from the work you did, and I think I
recall that you stated this register write broke the CSI2 configuration?

Can you clarify anything here for us please?

--
Kieran


> 
> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
> ---
>  drivers/media/i2c/imx335.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/imx335.c b/drivers/media/i2c/imx335.c
> index 7a37eb327ff4..927b4806a5d7 100644
> --- a/drivers/media/i2c/imx335.c
> +++ b/drivers/media/i2c/imx335.c
> @@ -249,7 +249,6 @@ static const struct imx335_reg mode_2592x1940_regs[] = {
>         {0x3794, 0x7a},
>         {0x3796, 0xa1},
>         {0x37b0, 0x36},
> -       {0x3a00, 0x01},
>  };
>  
>  static const struct imx335_reg raw10_framefmt_regs[] = {
> -- 
> 2.41.0
>

  reply	other threads:[~2024-01-31  9:52 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-31  5:52 [PATCH v2 0/5] imx335: Support additional link-freq and TPG Umang Jain
2024-01-31  5:52 ` [PATCH v2 1/5] media: i2c: imx335: Drop setting of 0x3a00 register Umang Jain
2024-01-31  9:52   ` Kieran Bingham [this message]
2024-01-31 10:32     ` Matthias Fend
2024-02-07  4:21       ` Umang Jain
2024-02-15 12:50         ` Sakari Ailus
2024-01-31  5:52 ` [PATCH v2 2/5] media: imx335: Use v4l2_link_freq_to_bitmap helper Umang Jain
2024-02-15 12:51   ` Sakari Ailus
2024-02-15 12:53     ` Sakari Ailus
2024-01-31  5:52 ` [PATCH v2 3/5] media: i2c: imx335: Support multiple link frequency Umang Jain
2024-02-15 12:53   ` Sakari Ailus
2024-01-31  5:52 ` [PATCH v2 4/5] media: i2c: imx335: Refactor power sequence to set controls Umang Jain
2024-01-31  5:52 ` [PATCH v2 5/5] media: i2c: imx335: Add support for test pattern generator Umang Jain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170669477439.1011926.18210850208916698098@ping.linuxembedded.co.uk \
    --to=kieran.bingham@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=matthias.fend@emfend.at \
    --cc=mchehab@kernel.org \
    --cc=sakari.ailus@linux.intel.com \
    --cc=umang.jain@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®