From: Sean Christopherson <seanjc@google.com>
To: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Mingwei Zhang <mizhang@google.com>
Cc: "H. Peter Anvin" <hpa@zytor.com>,
kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86/pmu: Fix type length error when reading pmu->fixed_ctr_ctrl
Date: Fri, 2 Feb 2024 16:11:29 -0800 [thread overview]
Message-ID: <170691180776.332020.3187581586977661860.b4-ty@google.com> (raw)
In-Reply-To: <20240123221220.3911317-1-mizhang@google.com>
On Tue, 23 Jan 2024 22:12:20 +0000, Mingwei Zhang wrote:
> Fix type length error since pmu->fixed_ctr_ctrl is u64 but the local
> variable old_fixed_ctr_ctrl is u8. Truncating the value leads to
> information loss at runtime. This leads to incorrect value in old_ctrl
> retrieved from each field of old_fixed_ctr_ctrl and causes incorrect code
> execution within the for loop of reprogram_fixed_counters(). So fix this
> type to u64.
>
> [...]
Applied to kvm-x86 fixes. I'll let it stew in -next for a few days before
sending a pull request to Paolo. Thanks!
[1/1] KVM: x86/pmu: Fix type length error when reading pmu->fixed_ctr_ctrl
https://github.com/kvm-x86/linux/commit/05519c86d699
--
https://github.com/kvm-x86/linux/tree/next
prev parent reply other threads:[~2024-02-03 0:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 22:12 Mingwei Zhang
2024-01-31 15:43 ` Sean Christopherson
2024-01-31 17:02 ` Dongli Zhang
2024-01-31 17:13 ` Mingwei Zhang
2024-02-01 17:28 ` Sean Christopherson
2024-02-01 18:30 ` Mingwei Zhang
2024-02-01 19:36 ` Sean Christopherson
2024-02-01 19:53 ` Mingwei Zhang
2024-02-01 22:53 ` Sean Christopherson
2024-02-01 23:00 ` Mingwei Zhang
2024-02-02 3:25 ` Zhang, Xiong Y
2024-02-02 17:07 ` Sean Christopherson
2024-02-03 0:11 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170691180776.332020.3187581586977661860.b4-ty@google.com \
--to=seanjc@google.com \
--cc=hpa@zytor.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mizhang@google.com \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome