From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1993338AC7C for ; Fri, 24 Apr 2026 09:43:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023787; cv=none; b=rC43mhvkBAzbhRTlm2FLt8uwGBxE7I4SBGVCwZUKTF2rwF/yy5nqLujXk0xxz1zZk4IBVgcq3SLfQuvgM6YQ7BgAEcODxbWbZi66/y2q4rkrIs7oNlCKaRxn4CKoE4XZ57u5jVFDXkm5jRSK4KTR5Bca0TO9isjAvllAf0eLbB8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1777023787; c=relaxed/simple; bh=1GBQR8G2n6aMoWw0TMUO+qQMoVYADfYP0sxtdfMQREs=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=W5rsmnI5BvlJsiggm1K8Y3cwgs2u+4bkz9jNlDHEInvJPhz6EysHZKI++3clBJ310Y0goBFWXWgh8b9t/uEKUMZCvFPpBOHhuq22/8ooYtq6WK/iDJD+yxCMDVwKXJ9Bw0Rh4T2Eoh8xbeNyluZ5IaO45P2DTz4xSTrtTBVam9c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Z0kWWs0H; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=V3mNySgW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Z0kWWs0H"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="V3mNySgW" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63O8ueAO2710093 for ; Fri, 24 Apr 2026 09:43:05 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= l3Xl9azwQ71YTf5iuXr2g/rv15sTTWVZVILP1WiTlxs=; b=Z0kWWs0HRRHhUCDh Bj6R0qs+G7JWX8+lBRaEq+R9aXQLYHqrINVCvQRw336uX+FhlREq2010BSNcPqOm j7ZQ2LygmT6ON8+r2IROtmo2LViFdmASZsEVwN3P7ZSsN/lo+d/CC9rV46X0NUrh +81SU5dsinCXFbzAKMXwSYeyc0z2E5H7f86O938PbuqKhI2lwKS2TePmw6sPS7uQ o4+Cqsi2yBQkv32EpFVb6qBwxMARcV/+Tzj88v+uuvznTz3fWrMImRHq9cYhNboY yMiYLPkTsLtPcVXej6Z+KSBYuhdtITJs5tmmikoQvv9+qs7EsFZ0XFS/Bnb8tC5k XfcqlA== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dqqu9uexc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 24 Apr 2026 09:43:04 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8ee2dfd63beso53234285a.1 for ; Fri, 24 Apr 2026 02:43:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1777023784; x=1777628584; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=l3Xl9azwQ71YTf5iuXr2g/rv15sTTWVZVILP1WiTlxs=; b=V3mNySgWRC3Nr5NDVctXzzfrv8X0cZ+r2I5tW51cXj1SKCbrMqgx+KIzydmwR+Vr3Y 0GbWSgHwBnC80EmFQBFLGU0pubhlm9pZoAk/3qWtuySP+y1JEG+pAaj2k18T6XruRojS bfb4W6NrgrfQf7J6fdUcztTjIBHGD4CmjA72uKMiMp+UttVbnTa3kxAACaZnueyLyYMJ FoFcmBVV2vxXrAelJQp9jMlgiiYM+V6ACr65SNnN3uBc2dhlTTPIWtiKFNQk0YISEGvF HlvD9UjR99NygWxjjCIY9XL54JCYBiiOSVaE+zpQbnxkQuEk8gi5JQfYbj90Z5/cF++p LP4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777023784; x=1777628584; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l3Xl9azwQ71YTf5iuXr2g/rv15sTTWVZVILP1WiTlxs=; b=P29x7GTENf6zz3LzVnB2quZF0HUnWoaJbrj8JQWqiII0UHc3rmBb33oFPGAea52pDm DouK19pzfwor1ixtl61ayVMxKU36VrAYV5M89tS4upgVa1A9VQFYnIp6r8PkoxHkjg6v t+/Axb4owLlViWW3KnUr+KhYSS5h7ZH/L+YtSqHVqg2Njh88noikzjBRgwoXQHdevI8m pA7PqAWBxIVYOfw6+QRi42ebq1XHcnsvTk+2gk4nq0lPYExR6GLamAHLLMatAPFnhn8T aH+f5iciVrfGrbOeKkJwr6heIPY1S8kQhA/KTsOgro4FtuTLTUtspphf+8rtx6vFf5Yt bnWw== X-Forwarded-Encrypted: i=1; AFNElJ/F7ZDnBzc6UupFPnTvSOra0V6PBCo1doL7V71i/YL17ltnZZfq2OM8nifjBsZY2FoSk1dSd/CDwsO3HdI=@vger.kernel.org X-Gm-Message-State: AOJu0YzLmnkCTsbfL7YGnOaNM35iUFxinn4RGzk8aws1Aaxs1/vvHlla l/ZGR5z8nxriuCuRU9nnFAM7WYWEuIpfDxWg344Tdb8BRpbuXPg5wPH1Tn+Vqb4Fgi/HH/mIXfL qoBW4G+/qDpfcXotpaPimwuh665bnf9Z00hamT6ZpZkV8s6FIkcXZW2781grBRBhgQKk= X-Gm-Gg: AeBDievfXQajQ2ESCSOf/72it2KpweX8LU19VrJpypGgdFmzy1HwI/br/0ncopdNu4y QggRGIEoe5vu/oSkLXyDryLXHCN8PKMDUTjITgmAiS28YQvG9jUtcb44YIPbnHgJ9h1dHmOhJur 5gdhNdZQlrofAhnL45PVrgcvBk3doAbCGKEsfesmNgXUMyGfUxD8YAtEc5pzjRdRLY7XSvfpOJs leI7tFMhMbWzerGvXVwYXvdEYMqchXMd8dCl0MTFJ4WzrlpEyJ+ySxEnpDeuqh9A2ZxfhPyC75O shFf6NIy0SjVeTeLKFaGCtGDmyiKj2E/pDNH1zZtYGgsg+voUwgFK+G70IXDDyHN84RJiUmfzFn lagcllRsRzSTU8Iv36l7dR/bf+ZxR/c870DYr1uLOmU1MPOC0X5gVk0Ld0DnWlrHlq5dXN4HZRn o8C5WJyBVcKe5+iA== X-Received: by 2002:ac8:5f0c:0:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-50e5e6ace9dmr207534191cf.1.1777023784267; Fri, 24 Apr 2026 02:43:04 -0700 (PDT) X-Received: by 2002:ac8:5f0c:0:b0:50e:5e6a:c7d5 with SMTP id d75a77b69052e-50e5e6ace9dmr207534041cf.1.1777023783763; Fri, 24 Apr 2026 02:43:03 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba4516f7b11sm754655766b.14.2026.04.24.02.43.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Apr 2026 02:43:02 -0700 (PDT) Message-ID: <1706c9ff-8c05-4855-be1a-1ff4c6792996@oss.qualcomm.com> Date: Fri, 24 Apr 2026 11:42:59 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v4 6/7] drm/msm/adreno: add Adreno 810 GPU support To: Alexander Koskovich Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Konrad Dybcio , Akhil P Oommen , Bjorn Andersson , Luca Weiss , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260416-adreno-810-v4-0-61676e073f8a@pm.me> <20260416-adreno-810-v4-6-61676e073f8a@pm.me> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: UEOfTM-cXsF5MUp5mNjR38aEme86JTXn X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDI0MDA5MCBTYWx0ZWRfXwsL3z9wo4j1O j1WvZ49wisPGy0dDQL/81fdJ78qjSCptPYni0Bc6xhcYnmwYBip0vrnA9ujkAQf58r7/DGlW6EX Fguw4Q0iVyjX5j3fTn+0OWGl+Yw3rLOAoYQCw9qDhvj0ZlEbhxrWnkVlUCwctaotmcs66xohpen oQIAR340lUHJR4AdfVFm4ujT4nqdeno9Gkf3sWuhUqhiUztU3DTsS+dVWeee2S9JfegaWAuYpi7 wHSNd4ltuZ+fUwYXCPwAMZQx7jklsaMZGbrz220/fAylDvrfZKYejaBzTuw9Ppklneky2N0vJYA zOyxvGaXeiVrHyYWJFXeMnD9Vspkd77VKzGey1SoPXwg4v96K9kSWw71/oBQ8WO/+6ibe5WC2DS TmqvuCec11v/LdU5zFVkjJFdqWWP+hTNAJe9GTWE2yrnIMEz9OblJqT6CGoyNGJ5XZFVetmczLQ B/oJpV4QbUbltUUU5AQ== X-Proofpoint-ORIG-GUID: UEOfTM-cXsF5MUp5mNjR38aEme86JTXn X-Authority-Analysis: v=2.4 cv=QJNYgALL c=1 sm=1 tr=0 ts=69eb3b28 cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=EUspDBNiAAAA:8 a=mNBZ_Hp9KTgF1tjAaBMA:9 a=QEXdDO2ut3YA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_03,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 phishscore=0 bulkscore=0 malwarescore=0 adultscore=0 impostorscore=0 priorityscore=1501 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604240090 On 4/23/26 10:27 PM, Alexander Koskovich wrote: > On Wednesday, April 22nd, 2026 at 9:04 AM, Konrad Dybcio wrote: > >> >> >> On 16-Apr-26 13:05, Alexander Koskovich wrote: >>> Add catalog entry and register configuration for the Adreno 810 >>> found in Qualcomm SM7635 (Milos) based devices. >>> >>> Signed-off-by: Alexander Koskovich >>> --- >>> drivers/gpu/drm/msm/adreno/a6xx_catalog.c | 296 ++++++++++++++++++++++++++++++ >>> drivers/gpu/drm/msm/adreno/adreno_gpu.h | 5 + >>> 2 files changed, 301 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>> index 550ff3a9b82e..1190804632d6 100644 >>> --- a/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_catalog.c >>> @@ -1799,6 +1799,259 @@ static const struct adreno_reglist_pipe x285_dyn_pwrup_reglist_regs[] = { >>> }; >>> DECLARE_ADRENO_REGLIST_PIPE_LIST(x285_dyn_pwrup_reglist); >>> >>> +static const struct adreno_reglist_pipe a810_nonctxt_regs[] = { >> >> To align with the latest kgsl which includes all the latest >> recommendations, remove: >> >> { REG_A8XX_SP_READ_SEL, 0x0001ff00, BIT(PIPE_NONE) }, >> >> { REG_A8XX_TPL1_DBG_ECO_CNTL, 0x10000000, BIT(PIPE_NONE) }, >> { REG_A8XX_TPL1_DBG_ECO_CNTL1, 0x00000724, BIT(PIPE_NONE) }, >> >> { REG_A8XX_UCHE_CACHE_WAYS, 0x00080000, BIT(PIPE_NONE) }, >> >> { REG_A8XX_VSC_BIN_SIZE, 0x00010001, BIT(PIPE_NONE) }, >> >> and add: >> >> (below RB_CCU_CNTL) >> { REG_A8XX_RB_CCU_DBG_ECO_CNTL, 0x00002200, BIT(PIPE_BR) }, >> >> (swap in place) >> { REG_A8XX_TPL1_DBG_ECO_CNTL, 0x10100000, BIT(PIPE_NONE) }, >> { REG_A8XX_TPL1_DBG_ECO_CNTL1, 0x04000724, BIT(PIPE_NONE) }, >> >> (below UCHE_CCHE_CACHE_WAYS) >> { REG_A8XX_UCHE_HW_DBG_CNTL, BIT(8), BIT(PIPE_NONE) }, >> >> (below RB_GC_GMEM_PROTECT) >> { REG_A8XX_RB_CCU_DBG_ECO_CNTL, 0x00002200, BIT(PIPE_BR) }, > > Just wanted to clarify if this was a typo, since you also asked for RB_CCU_DBG_ECO_CNTL below RB_CCU_CNTL as well. Looks like kgsl has a duplicate entry here. Just one is enough! Konrad