From: "Randy.Dunlap" <rddunlap@osdl.org>
To: <rusty@rustcorp.com.au>
Cc: <torvalds@transmeta.com>, <rth@twiddle.net>,
<linux-kernel@vger.kernel.org>, <kai@tp1.ruhr-uni-bochum.de>
Subject: Re: [PATCH] eliminate warnings in generated module files
Date: Tue, 25 Feb 2003 19:35:58 -0800 (PST) [thread overview]
Message-ID: <1707.4.64.238.61.1046230558.squirrel@www.osdl.org> (raw)
In-Reply-To: <20030226012305.A31342C158@lists.samba.org>
> In message <Pine.LNX.4.44.0302251546590.2185-100000@home.transmeta.com> you
> wri te:
>>
>> On Tue, 25 Feb 2003, Rusty Russell wrote:
>> >
>> > __optional should always be __attribute__((__unused__)), and
>> > __required should be your __attribute_used__.
>>
>> But I think rth's point was that "__module_depends" should definitely
>> _not_ be "optional", since that just means that the compiler can (and
>> will) optimize away the whole thing.
>>
>> So marking it optional is definitely the wrong thing to do.
>
> This time for sure!
>
> Name: __optional attribute
> Author: Rusty Russell
> Status: Trivial
I have to agree with Kai and Milton Miller on this (bad) naming.
__required and __optional don't generate the corrent connotations
of what is being attempted here.
Milton suggesting spelling __attribute_used__ as __keep or
__needed. I prefer __attribute_used__, but something like
__mark_as_used__ would be OK too.
And what uses __optional, however it is spelled?
Thanks,
~Randy
next prev parent reply other threads:[~2003-02-26 3:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-02-19 2:43 Richard Henderson
2003-02-19 3:29 ` Linus Torvalds
2003-02-19 3:43 ` Richard Henderson
2003-02-19 5:16 ` Linus Torvalds
2003-02-19 6:16 ` Richard Henderson
2003-02-19 20:11 ` Kai Germaschewski
2003-02-19 21:05 ` Richard Henderson
2003-02-20 0:01 ` Rusty Russell
2003-02-19 23:41 ` Chris Wedgwood
2003-02-25 4:32 ` Rusty Russell
2003-02-25 7:58 ` Richard Henderson
2003-02-25 11:39 ` Rusty Russell
2003-02-25 23:47 ` Linus Torvalds
2003-02-26 1:22 ` Rusty Russell
2003-02-26 1:36 ` Kai Germaschewski
2003-02-26 4:13 ` Rusty Russell
2003-02-26 17:02 ` Horst von Brand
2003-02-26 17:04 ` Richard Henderson
2003-02-26 3:35 ` Randy.Dunlap [this message]
2003-02-26 4:08 ` Rusty Russell
2003-02-26 13:45 ` Werner Almesberger
2003-02-25 21:42 ` Chris Wedgwood
2003-02-26 2:23 Milton D. Miller II
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1707.4.64.238.61.1046230558.squirrel@www.osdl.org \
--to=rddunlap@osdl.org \
--cc=kai@tp1.ruhr-uni-bochum.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rth@twiddle.net \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®