From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f182.google.com (mail-il1-f182.google.com [209.85.166.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C98544C60 for ; Mon, 5 Feb 2024 17:16:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707153392; cv=none; b=TFr6pwIUJqC90ZzZUAijl5IZTPMlxcQbzq+hmSl813H3yfww1XiYGb8wnGiESNASgjViTMGE5c8Ab0TxoxTrE9MaJlXvRrHVc7gH9R4TncaFeJXODoVGuwnS1NdGEdxmlsHQdNI7LXQ9HeIohgBOHh5gdSU3iDsatC5z2LLQows= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707153392; c=relaxed/simple; bh=piaR+OlvSafD8F9Muj4jdMl0CtYQbMZ6TzkK428/s98=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=XXodhbnAQBWjaI35E3yOSiKjzNreehjim45dNMTiTa4A+t29GNDjlk8EnAT4nyxBDEsimkzkjt+CWGRIGy5HJs5pX2I12PhRkA+C4pzRpe4kxmQvNvsubb0/23Vv4fsZihw6M3aAc+7pY9j8kSNDpcz9gQ+Y1KjOM+1qibg36as= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk; spf=pass smtp.mailfrom=kernel.dk; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b=xKBvo8yv; arc=none smtp.client-ip=209.85.166.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.dk Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=kernel.dk Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20230601.gappssmtp.com header.i=@kernel-dk.20230601.gappssmtp.com header.b="xKBvo8yv" Received: by mail-il1-f182.google.com with SMTP id e9e14a558f8ab-363bfee81e4so2495765ab.1 for ; Mon, 05 Feb 2024 09:16:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20230601.gappssmtp.com; s=20230601; t=1707153388; x=1707758188; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Sn9JODr/JoAaSiGEhGpmDiigEzzGF4d02eSYaBgfml0=; b=xKBvo8yvMUDgPC0HrVnmgUyPwvNnjCn76URLRnB8xXGKiE4Of33of9UHg99IwH+y7z 5xFE+QhGN0c3y6dGdWcUx5m3H9/KqX2N7/e82jrHve1Oj9ynr6kKTNFJh2Q+YmbnpkgH 8gbsQBcInn1FSEXw54Gfw27csdMEeK8JgQHUgP1y9v8G1pM/TrT/b7E6ZIRaZJn+F4fn I+W4kUTezPMz1xtdKJI64VKIH0lMVnnljJTRiS4UJAfzQ+JAAKVomchNScMAbuSkKcj1 +15iHAxDnJRV1e4Zwn7A60fwL/sc8jEfjv689CCvqyiGNOZaFcNdU4ksgpKqEI396iDr Q5ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707153388; x=1707758188; h=content-transfer-encoding:mime-version:date:message-id:subject :references:in-reply-to:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Sn9JODr/JoAaSiGEhGpmDiigEzzGF4d02eSYaBgfml0=; b=Ld3LaQttbF9gcfI/C6DSHkSzGWYW81VZ2vrQE3X9jlrZIEPZoTiKqTBKh72bGhWFZb kOciNtTQYAa9kfvG+7U03MVm9SqS59lB/LqJAky4trQMbyuduLdQszKNv6yxeWgwZ+ba EELbb7RSORhGGst9IMmg+onjuccL87ujPk7a72ccIWJcuDlz7jiXL7tCOM8a9tmSoCuj 0fh2Gi3U2f9efZEswAtHCpwTrcIVxcuMKdLyyhAf25urOlIQsM2oS6ELRtHqlSfmkSuD wQ+yB/BIrom1YGIc0N2uT5jM8v2HavRS8GxogXghwCqUjmSNkx1UxzxRpwjMe6H/9UpI ziYw== X-Forwarded-Encrypted: i=1; AJvYcCXJj76qi/L8AWEwgwcjn5HytY4QOxOkvOhDMnBnb9gmLODoNxieICM70OZTOJCbn/iT1fGp1duqD15mYq0QolhIg5rwsFbdt5H6ZtWl X-Gm-Message-State: AOJu0Yypqh154X3Jv4TE3lYHI4s3NElYEEX3tQF5ywSVTTXon7fTih6h hck0aSf88gSOo0yUFbR/dwpUwFihXTKuqbAkQVxmIv4RQz7H25a2NnadC3VV/tbVVDFX1hqoIa9 ePCQ= X-Google-Smtp-Source: AGHT+IF9xzHnKqV2+QFxIe4MP6yuw8AhazZJSLemHsDNED3aABwGp5oU+CSGl6UoDPC7tTCpMoE/ew== X-Received: by 2002:a92:c26c:0:b0:363:b9d6:126a with SMTP id h12-20020a92c26c000000b00363b9d6126amr439549ild.1.1707153388555; Mon, 05 Feb 2024 09:16:28 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCUrkCvJqfZ0mquUR3S2ekjLknyUXgZyySSTKgxjk3t4MKFUWRnYDJOteX+ZDPI/odTvcid6HF38RUeLjVNFyblhKXUOvxqEoxyKT+tBJhoJkKAqBpME3YIv+Z7DsnuEKv/RupbOLoeyJF33JZnX1n1Q4dVot2qvM/El75dYZSwE8laH4uuthX8oowiYTS4UIEli4Ok3wLs= Received: from [127.0.0.1] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id k1-20020a056e0205a100b00363c4838148sm26844ils.24.2024.02.05.09.16.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Feb 2024 09:16:27 -0800 (PST) From: Jens Axboe To: tj@kernel.org, Tang Yizhou Cc: linux-block@vger.kernel.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, chunguang.xu@shopee.com In-Reply-To: <20240123081248.3752878-1-yizhou.tang@shopee.com> References: <20240123081248.3752878-1-yizhou.tang@shopee.com> Subject: Re: [PATCH] blk-throttle: Eliminate redundant checks for data direction Message-Id: <170715338749.494668.12422641038980561010.b4-ty@kernel.dk> Date: Mon, 05 Feb 2024 10:16:27 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.12.5-dev-2aabd On Tue, 23 Jan 2024 16:12:48 +0800, Tang Yizhou wrote: > After calling throtl_peek_queued(), the data direction can be determined so > there is no need to call bio_data_dir() to check the direction again. > > Applied, thanks! [1/1] blk-throttle: Eliminate redundant checks for data direction commit: 3bca7640b4c50621b94365a1746f4b86116fec56 Best regards, -- Jens Axboe