mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kieran Bingham <kieran.bingham@ideasonboard.com>
To: Michael Grzeschik <mgr@pengutronix.de>,
	Thinh Nguyen <Thinh.Nguyen@synopsys.com>
Cc: linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>,
	linux-usb@vger.kernel.org <linux-usb@vger.kernel.org>
Subject: Re: duplicate requests on host side while streaming via uvcvideo gadget
Date: Wed, 07 Feb 2024 13:04:48 +0000	[thread overview]
Message-ID: <170731108881.252503.6282895768429052406@ping.linuxembedded.co.uk> (raw)
In-Reply-To: <ZcKk6QJXfGGo2DH9@pengutronix.de>

Hi Michael,

Quoting Michael Grzeschik (2024-02-06 21:30:17)
> On Tue, Feb 06, 2024 at 03:23:17AM +0000, Thinh Nguyen wrote:
> >On Tue, Feb 06, 2024, Michael Grzeschik wrote:
> >> Hi Thinh
> >>
> >> I found some strange situation while streaming via uvc-gadget to some
> >> usb host. It happens when some requests are missed due to higher load on
> >> the gadget machine. In some cases some requests will reach the host
> >> twice. In my special case, I added the following changes [1] for the
> >> host and gadget side.
> >
> >Does this only happen to some specific hosts?
> 
> >Are all the data of the duplicate requests matching or just some bits of
> >the transfer? Were you able to confirm from some usb analyzer/sniffer
> >that the data out the wire is actually duplicate?
> 
> Turns out, this duplicates are just misinterpretations.

I'm glad there's no deeper issue to worry about here.

> The linux uvcvideo driver will parse the uvc header payload twice. (If
> the FID was incremented inbetween). This led to those double misleading
> outputs. Although this means that there is a bug in
> uvc_video_stats_decode for incrementing the error count.

Do you plan/are you able to submit a patch to fix this?  Hopefully that
would prevent anyone else following the same rabbit-hole.

--
Kieran


> 
> Anyway, so just ignore this whole thread and be thanked for even having any
> thoghts on this.
> 
> Regards,
> Michael
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

  reply	other threads:[~2024-02-07 13:04 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-05 23:40 Michael Grzeschik
2024-02-06  3:23 ` Thinh Nguyen
2024-02-06 21:30   ` Michael Grzeschik
2024-02-07 13:04     ` Kieran Bingham [this message]
2024-02-07 13:10       ` Michael Grzeschik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=170731108881.252503.6282895768429052406@ping.linuxembedded.co.uk \
    --to=kieran.bingham@ideasonboard.com \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgr@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®