From: Will Deacon <will@kernel.org>
To: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Fangrui Song <maskray@google.com>
Cc: kernel-team@android.com, Will Deacon <will@kernel.org>,
Ard Biesheuvel <ardb@kernel.org>,
Peter Smith <peter.smith@arm.com>,
Jisheng Zhang <jszhang@kernel.org>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Dave Martin <Dave.Martin@arm.com>
Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i"
Date: Fri, 9 Feb 2024 18:31:08 +0000 [thread overview]
Message-ID: <170749826521.2630324.4507897270923627883.b4-ty@kernel.org> (raw)
In-Reply-To: <20240206074552.541154-1-maskray@google.com>
On Mon, 5 Feb 2024 23:45:52 -0800, Fangrui Song wrote:
> The generic constraint "i" seems to be copied from x86 or arm (and with
> a redundant generic operand modifier "c"). It works with -fno-PIE but
> not with -fPIE/-fPIC in GCC's aarch64 port.
>
> The machine constraint "S", which denotes a symbol or label reference
> with a constant offset, supports PIC and has been available in GCC since
> 2012 and in Clang since 7.0. However, Clang before 19 does not support
> "S" on a symbol with a constant offset [1] (e.g.
> `static_key_false(&nf_hooks_needed[pf][hook])` in
> include/linux/netfilter.h), so we use "i" as a fallback.
>
> [...]
Applied to arm64 (for-next/fixes), thanks!
[1/1] arm64: jump_label: use constraints "Si" instead of "i"
https://git.kernel.org/arm64/c/f9daab0ad01c
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
next prev parent reply other threads:[~2024-02-09 18:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 7:45 Fangrui Song
2024-02-09 11:11 ` Mark Rutland
2024-02-09 18:31 ` Will Deacon [this message]
2024-02-19 10:03 ` Geert Uytterhoeven
2024-02-19 10:56 ` Ard Biesheuvel
2024-02-19 10:57 ` Ard Biesheuvel
2024-02-19 14:42 ` Geert Uytterhoeven
2024-02-19 15:41 ` Ard Biesheuvel
2024-02-19 17:06 ` Arnd Bergmann
2024-02-19 18:22 ` Mark Rutland
2024-02-20 7:55 ` Ard Biesheuvel
2024-02-20 8:49 ` Ard Biesheuvel
2024-02-20 12:05 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170749826521.2630324.4507897270923627883.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=Dave.Martin@arm.com \
--cc=ardb@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=jszhang@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=maskray@google.com \
--cc=peter.smith@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®