From: "tip-bot2 for Bibo Mao" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Bibo Mao <maobibo@loongson.cn>,
Thomas Gleixner <tglx@linutronix.de>,
Huacai Chen <chenhuacai@loongson.cn>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] irqchip/loongson-eiointc: Skip handling if there is no pending interrupt
Date: Tue, 13 Feb 2024 09:57:00 -0000 [thread overview]
Message-ID: <170781822030.398.1776508583120983829.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20240130082722.2912576-3-maobibo@loongson.cn>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 3eece72ded7f67776731709702f3d1b9893b6a4f
Gitweb: https://git.kernel.org/tip/3eece72ded7f67776731709702f3d1b9893b6a4f
Author: Bibo Mao <maobibo@loongson.cn>
AuthorDate: Tue, 30 Jan 2024 16:27:21 +08:00
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Tue, 13 Feb 2024 10:53:14 +01:00
irqchip/loongson-eiointc: Skip handling if there is no pending interrupt
eiointc_irq_dispatch() iterates over the pending bit registers of the
interrupt controller and evaluates the result even if there is no interrupt
pending in a particular 64bit chunk.
Skip handling and especially the pointless write back for clearing the
non-pending bits if a chunk is empty.
[ tglx: Massaged changelog ]
Signed-off-by: Bibo Mao <maobibo@loongson.cn>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Huacai Chen <chenhuacai@loongson.cn>
Link: https://lore.kernel.org/r/20240130082722.2912576-3-maobibo@loongson.cn
---
drivers/irqchip/irq-loongson-eiointc.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/irqchip/irq-loongson-eiointc.c b/drivers/irqchip/irq-loongson-eiointc.c
index 1623cd7..fad22e2 100644
--- a/drivers/irqchip/irq-loongson-eiointc.c
+++ b/drivers/irqchip/irq-loongson-eiointc.c
@@ -198,6 +198,12 @@ static void eiointc_irq_dispatch(struct irq_desc *desc)
for (i = 0; i < eiointc_priv[0]->vec_count / VEC_COUNT_PER_REG; i++) {
pending = iocsr_read64(EIOINTC_REG_ISR + (i << 3));
+
+ /* Skip handling if pending bitmap is zero */
+ if (!pending)
+ continue;
+
+ /* Clear the IRQs */
iocsr_write64(pending, EIOINTC_REG_ISR + (i << 3));
while (pending) {
int bit = __ffs(pending);
next prev parent reply other threads:[~2024-02-13 9:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 8:27 [PATCH v5 0/3] irqchip/loongson-eiointc: Refine irq affinity setting during resume Bibo Mao
2024-01-30 8:27 ` [PATCH v5 1/3] irqchip/loongson-eiointc: Typo fix in function eiointc_domain_alloc Bibo Mao
2024-02-13 8:46 ` Thomas Gleixner
2024-02-13 9:31 ` [tip: irq/urgent] irqchip/loongson-eiointc: Use correct struct type in eiointc_domain_alloc() tip-bot2 for Bibo Mao
2024-01-30 8:27 ` [PATCH v5 2/3] irqchip/loongson-eiointc: Skip handling if there is no pending irq Bibo Mao
2024-02-13 9:57 ` tip-bot2 for Bibo Mao [this message]
2024-01-30 8:27 ` [PATCH v5 3/3] irqchip/loongson-eiointc: Refine irq affinity setting during resume Bibo Mao
2024-02-13 9:49 ` Thomas Gleixner
2024-02-17 3:32 ` maobibo
2024-03-13 6:20 ` Huacai Chen
2024-03-13 12:39 ` Thomas Gleixner
2024-03-14 14:34 ` Huacai Chen
2024-02-13 9:56 ` [tip: irq/core] irqchip/loongson-eiointc: Remove explicit interrupt affinity restore on resume tip-bot2 for Bibo Mao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170781822030.398.1776508583120983829.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=chenhuacai@loongson.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maobibo@loongson.cn \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®