From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Colin King <colin.king@canonical.com>
Cc: linux-pm@vger.kernel.org, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: ACPI: make function acpi_cpufreq_fast_switch static
Date: Tue, 12 Jun 2018 17:00:55 +0200 [thread overview]
Message-ID: <1707897.EI8LSjriHK@aspire.rjw.lan> (raw)
In-Reply-To: <20180604071141.wzxjtxa2hwlbkaw3@vireshk-i7>
On Monday, June 4, 2018 9:11:41 AM CEST Viresh Kumar wrote:
> On 01-06-18, 14:05, Colin King wrote:
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > The function acpi_cpufreq_fast_switch is local to the source and does
> > not need to be in global scope, so make it static.
> >
> > Cleans up sparse warning:
> > drivers/cpufreq/acpi-cpufreq.c:468:14: warning: symbol
> > 'acpi_cpufreq_fast_switch' was not declared. Should it be static?
> >
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/cpufreq/acpi-cpufreq.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/cpufreq/acpi-cpufreq.c b/drivers/cpufreq/acpi-cpufreq.c
> > index 9449657d72f0..32ba4bc972e7 100644
> > --- a/drivers/cpufreq/acpi-cpufreq.c
> > +++ b/drivers/cpufreq/acpi-cpufreq.c
> > @@ -465,8 +465,8 @@ static int acpi_cpufreq_target(struct cpufreq_policy *policy,
> > return result;
> > }
> >
> > -unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> > - unsigned int target_freq)
> > +static unsigned int acpi_cpufreq_fast_switch(struct cpufreq_policy *policy,
> > + unsigned int target_freq)
> > {
> > struct acpi_cpufreq_data *data = policy->driver_data;
> > struct acpi_processor_performance *perf;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
Patch applied, thanks!
prev parent reply other threads:[~2018-06-12 15:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-01 13:05 Colin King
2018-06-04 7:11 ` Viresh Kumar
2018-06-12 15:00 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1707897.EI8LSjriHK@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=colin.king@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®