From: Kalle Valo <kvalo@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>,
Nathan Chancellor <nathan@kernel.org>,
Greg Kroah-Hartman <gregkh@suse.de>,
Pieter-Paul Giesberts <pieterpg@broadcom.com>,
Arnd Bergmann <arnd@arndb.de>,
Nick Desaulniers <ndesaulniers@google.com>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
Artem Chernyshev <artem.chernyshev@red-soft.ru>,
Jonas Gorski <jonas.gorski@gmail.com>,
linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
brcm80211-dev-list.pdl@broadcom.com,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev
Subject: Re: wifi: brcmsmac: avoid function pointer casts
Date: Fri, 16 Feb 2024 15:49:17 +0000 (UTC) [thread overview]
Message-ID: <170809855575.4095987.6738667810057679701.kvalo@kernel.org> (raw)
In-Reply-To: <20240213100548.457854-1-arnd@kernel.org>
Arnd Bergmann <arnd@kernel.org> wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> An old cleanup went a little too far and causes a warning with clang-16
> and higher as it breaks control flow integrity (KCFI) rules:
>
> drivers/net/wireless/broadcom/brcm80211/brcmsmac/phy_shim.c:64:34: error: cast from 'void (*)(struct brcms_phy *)' to 'void (*)(void *)' converts to incompatible function type [-Werror,-Wcast-function-type-strict]
> 64 | brcms_init_timer(physhim->wl, (void (*)(void *))fn,
> | ^~~~~~~~~~~~~~~~~~~~
>
> Change this one instance back to passing a void pointer so it can be
> used with the timer callback interface.
>
> Fixes: d89a4c80601d ("staging: brcm80211: removed void * from softmac phy")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Acked-by: Arend van Spriel <arend.vanspriel@broadcom.com>
Patch applied to wireless-next.git, thanks.
e1ea6db35fc3 wifi: brcmsmac: avoid function pointer casts
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240213100548.457854-1-arnd@kernel.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
prev parent reply other threads:[~2024-02-16 15:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-13 10:05 [PATCH] " Arnd Bergmann
2024-02-14 8:45 ` Kalle Valo
2024-02-14 9:23 ` Arend van Spriel
2024-02-14 15:07 ` Arnd Bergmann
2024-02-14 17:55 ` Kalle Valo
2024-02-15 10:33 ` Kalle Valo
2024-02-15 13:48 ` Arend Van Spriel
2024-02-16 15:49 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170809855575.4095987.6738667810057679701.kvalo@kernel.org \
--to=kvalo@kernel.org \
--cc=arend.vanspriel@broadcom.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=artem.chernyshev@red-soft.ru \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=gregkh@suse.de \
--cc=jonas.gorski@gmail.com \
--cc=justinstitt@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=pieterpg@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®