From: Jens Axboe <axboe@kernel.dk>
To: song@kernel.org, yukuai3@huawei.com, linan666@huaweicloud.com
Cc: linux-raid@vger.kernel.org, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, yi.zhang@huawei.com,
houtao1@huawei.com, yangerkun@huawei.com
Subject: Re: [PATCH v2] block: fix deadlock between bd_link_disk_holder and partition scan
Date: Fri, 23 Feb 2024 07:46:46 -0700 [thread overview]
Message-ID: <170869960618.48825.8696438313079266889.b4-ty@kernel.dk> (raw)
In-Reply-To: <20240221090122.1281868-1-linan666@huaweicloud.com>
On Wed, 21 Feb 2024 17:01:22 +0800, linan666@huaweicloud.com wrote:
> 'open_mutex' of gendisk is used to protect open/close block devices. But
> in bd_link_disk_holder(), it is used to protect the creation of symlink
> between holding disk and slave bdev, which introduces some issues.
>
> When bd_link_disk_holder() is called, the driver is usually in the process
> of initialization/modification and may suspend submitting io. At this
> time, any io hold 'open_mutex', such as scanning partitions, can cause
> deadlocks. For example, in raid:
>
> [...]
Applied, thanks!
[1/1] block: fix deadlock between bd_link_disk_holder and partition scan
commit: 03f12122b20b6e6028e9ed69030a49f9cffcbb75
Best regards,
--
Jens Axboe
prev parent reply other threads:[~2024-02-23 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-21 9:01 linan666
2024-02-22 9:26 ` Yu Kuai
2024-02-23 6:48 ` Christoph Hellwig
2024-02-23 14:46 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=170869960618.48825.8696438313079266889.b4-ty@kernel.dk \
--to=axboe@kernel.dk \
--cc=houtao1@huawei.com \
--cc=linan666@huaweicloud.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®